From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvrgK-0000lv-Qc for qemu-devel@nongnu.org; Thu, 17 Jan 2013 10:47:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvrgE-0004OR-Hs for qemu-devel@nongnu.org; Thu, 17 Jan 2013 10:47:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:17372) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvrgE-0004OG-AJ for qemu-devel@nongnu.org; Thu, 17 Jan 2013 10:47:02 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0HFl1qG017615 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 17 Jan 2013 10:47:01 -0500 From: Stefan Hajnoczi Date: Thu, 17 Jan 2013 16:46:54 +0100 Message-Id: <1358437614-14968-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH] dataplane: support viostor virtio-pci status bit setting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , vrozenfe@redhat.com, Stefan Hajnoczi , "Michael S. Tsirkin" The viostor virtio-blk driver for Windows does not use the VIRTIO_CONFIG_S_DRIVER bit. It only sets the VIRTIO_CONFIG_S_DRIVER_OK bit. The viostor driver refreshes the virtio-pci status byte sometimes while the guest is running. We misinterpret 0x4 (VIRTIO_CONFIG_S_DRIVER_OK) as an indication that virtio-blk-data-plane should be stopped since 0x2 (VIRTIO_CONFIG_S_DRIVER) is missing. The result is that the device becomes unresponsive. Signed-off-by: Stefan Hajnoczi --- hw/virtio-blk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index df57b35..34913ee 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.c @@ -571,7 +571,8 @@ static void virtio_blk_set_status(VirtIODevice *vdev, uint8_t status) uint32_t features; #ifdef CONFIG_VIRTIO_BLK_DATA_PLANE - if (s->dataplane && !(status & VIRTIO_CONFIG_S_DRIVER)) { + if (s->dataplane && !(status & (VIRTIO_CONFIG_S_DRIVER | + VIRTIO_CONFIG_S_DRIVER_OK))) { virtio_blk_data_plane_stop(s->dataplane); } #endif -- 1.8.0.2