From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvwLC-00065U-OY for qemu-devel@nongnu.org; Thu, 17 Jan 2013 15:45:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvwL9-00041v-GC for qemu-devel@nongnu.org; Thu, 17 Jan 2013 15:45:38 -0500 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:46742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvwL9-00041J-89 for qemu-devel@nongnu.org; Thu, 17 Jan 2013 15:45:35 -0500 From: Stefan Weil Date: Thu, 17 Jan 2013 21:45:23 +0100 Message-Id: <1358455528-29813-1-git-send-email-sw@weilnetz.de> Subject: [Qemu-devel] [PATCH v2 0/5] block: Fix error report for wrong file format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi These patches improve the error report if the file format was specified explicitly (example: -drive file=myfile,format=qcow2) and the given format does not match the real format. They fix those bugs: https://bugzilla.redhat.com/show_bug.cgi?id=556482 https://bugs.launchpad.net/qemu/+bug/1090600 Changes in v2: * Use error code EMEDIUMTYPE instead of inventing a new one. * Split modifications in block/vdi.c into 3 separate patches. I decided to use EMEDIUMTYPE because I think that it matches best the kind of error which we want to describe here. EINVAL is too unspecific, and ENOTTY means something completely different, therefore I did not use one of those suggested values. Cheers, Stefan [PATCH v2 1/5] block: Add special error code for wrong format [PATCH v2 2/5] block: Use error code EMEDIUMTYPE for wrong format in [PATCH v2 3/5] block/vdi: Improve debug output for signature [PATCH v2 4/5] block/vdi: Improved return values from vdi_open [PATCH v2 5/5] block/vdi: Check for bad signature