qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 2/8] ide: Remove wrong assertion
Date: Fri, 18 Jan 2013 17:28:35 +0100	[thread overview]
Message-ID: <1358526521-24300-3-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1358526521-24300-1-git-send-email-stefanha@redhat.com>

From: Kevin Wolf <kwolf@redhat.com>

The Bus Master IDE Active bit (BM_STATUS_DMAING) is not only set when
the request is still in flight, but also when it has completed and the
size of the physical memory regions in the PRDT was larger than the
transfer size.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/ide/pci.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/ide/pci.c b/hw/ide/pci.c
index e6226e3..59fd539 100644
--- a/hw/ide/pci.c
+++ b/hw/ide/pci.c
@@ -311,7 +311,6 @@ void bmdma_cmd_writeb(BMDMAState *bm, uint32_t val)
             if (bm->bus->dma->aiocb) {
                 bdrv_drain_all();
                 assert(bm->bus->dma->aiocb == NULL);
-                assert((bm->status & BM_STATUS_DMAING) == 0);
             }
         } else {
             bm->cur_addr = bm->addr;
-- 
1.8.0.2

  parent reply	other threads:[~2013-01-18 16:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-18 16:28 [Qemu-devel] [PULL for-1.4 0/8] Block patches Stefan Hajnoczi
2013-01-18 16:28 ` [Qemu-devel] [PATCH 1/8] block: fix null-pointer bug on error case in block commit Stefan Hajnoczi
2013-01-18 16:28 ` Stefan Hajnoczi [this message]
2013-01-18 16:28 ` [Qemu-devel] [PATCH 3/8] aio: Fix return value of aio_poll() Stefan Hajnoczi
2013-01-18 16:28 ` [Qemu-devel] [PATCH 4/8] win32-aio: Fix vectored reads Stefan Hajnoczi
2013-01-18 16:28 ` [Qemu-devel] [PATCH 5/8] win32-aio: Fix memory leak Stefan Hajnoczi
2013-01-18 16:28 ` [Qemu-devel] [PATCH 6/8] win32-aio: use iov utility functions instead of open-coding them Stefan Hajnoczi
2013-01-18 16:28 ` [Qemu-devel] [PATCH 7/8] dataplane: avoid reentrancy during virtio_blk_data_plane_stop() Stefan Hajnoczi
2013-01-18 16:28 ` [Qemu-devel] [PATCH 8/8] dataplane: support viostor virtio-pci status bit setting Stefan Hajnoczi
2013-01-20 20:49 ` [Qemu-devel] [PULL for-1.4 0/8] Block patches Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358526521-24300-3-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).