From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53920) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwEoL-0001Ld-7m for qemu-devel@nongnu.org; Fri, 18 Jan 2013 11:29:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TwEoI-0004v1-Fo for qemu-devel@nongnu.org; Fri, 18 Jan 2013 11:28:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwEoI-0004u1-6X for qemu-devel@nongnu.org; Fri, 18 Jan 2013 11:28:54 -0500 From: Stefan Hajnoczi Date: Fri, 18 Jan 2013 17:28:35 +0100 Message-Id: <1358526521-24300-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1358526521-24300-1-git-send-email-stefanha@redhat.com> References: <1358526521-24300-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH 2/8] ide: Remove wrong assertion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Anthony Liguori , Stefan Hajnoczi From: Kevin Wolf The Bus Master IDE Active bit (BM_STATUS_DMAING) is not only set when the request is still in flight, but also when it has completed and the size of the physical memory regions in the PRDT was larger than the transfer size. Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- hw/ide/pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/ide/pci.c b/hw/ide/pci.c index e6226e3..59fd539 100644 --- a/hw/ide/pci.c +++ b/hw/ide/pci.c @@ -311,7 +311,6 @@ void bmdma_cmd_writeb(BMDMAState *bm, uint32_t val) if (bm->bus->dma->aiocb) { bdrv_drain_all(); assert(bm->bus->dma->aiocb == NULL); - assert((bm->status & BM_STATUS_DMAING) == 0); } } else { bm->cur_addr = bm->addr; -- 1.8.0.2