From: Laurent Vivier <Laurent@Vivier.EU>
To: kwolf@redhat.com, Laurent@vivier.eu
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Introduce NBD named exports.
Date: Wed, 25 Aug 2010 11:35:00 +0200 [thread overview]
Message-ID: <1358581.137647.1282728894522.JavaMail.servlet@pustefix160.kundenserver.de> (raw)
>Am 25.08.2010 00:21, schrieb Laurent Vivier:
>> Le mardi 24 août 2010 à 10:59 +0200, Kevin Wolf a écrit :
>[...]
>
>>> Maybe using strlen(EN_OPTSTR) would be clearer? At first I missed the
>>> fact that sizeof includes the null byte, but maybe it's just me.
>>
>> I think sizeof() is resolved at compile time whereas strlen() it is at
>> runtime. For me, it is better, it is like to have a constant.
>
>gcc is smart enough to make strlen of a literal string a constant, too.
>Besides, opening a connection isn't really performance critical.
>
Yes, you're right, I should check this before. So strlen() is better.
Regards,
Laurent
--
--------------------- Laurent@vivier.eu ---------------------
"Tout ce qui est impossible reste à accomplir" Jules Verne
"Things are only impossible until they're not" Jean-Luc Picard
next reply other threads:[~2010-08-25 9:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 9:35 Laurent Vivier [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-08-24 1:04 [Qemu-devel] [PATCH] Introduce NBD named exports Laurent Vivier
2010-08-24 8:59 ` Kevin Wolf
2010-08-24 22:21 ` Laurent Vivier
2010-08-25 8:21 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358581.137647.1282728894522.JavaMail.servlet@pustefix160.kundenserver.de \
--to=laurent@vivier.eu \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).