From: David Woodhouse <dwmw2@infradead.org>
To: info@vruppert.de
Cc: vgabios-developers@nongnu.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes
Date: Sun, 20 Jan 2013 12:12:14 -0600 [thread overview]
Message-ID: <1358705534.20334.53.camel@shinybook.infradead.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 779 bytes --]
The PCI Firmware Specification apparently requires that the PCI Data
Structure be DWORD-aligned. The implementation in OVMF also requires
this, so vgabios ROMs don't work there. With this fixed, I can now
initialise the VGA ROM from EFI, and EFI can display using INT 10h
services.
--- vgabios-0.6c/vgabios.c.orig 2013-01-20 11:33:36.138548472 -0600
+++ vgabios-0.6c/vgabios.c 2013-01-20 11:36:26.060270163 -0600
@@ -204,6 +204,7 @@ vgabios_website:
.byte 0x00
#ifdef PCIBIOS
+.align 4 // DWORD alignment required by PCI Firmware Specification
vgabios_pci_data:
.ascii "PCIR"
#ifdef CIRRUS
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6171 bytes --]
next reply other threads:[~2013-01-20 19:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-20 18:12 David Woodhouse [this message]
2013-09-13 0:05 ` [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes Brad Smith
-- strict thread matches above, loose matches on Subject: below --
2013-09-19 16:53 Sebastian Herbszt
2013-09-20 22:43 ` Brad Smith
2013-09-21 16:38 ` Sebastian Herbszt
2013-09-25 23:24 ` Brad Smith
2013-10-09 1:56 ` Brad Smith
2013-10-09 15:18 ` Andreas Färber
2013-10-10 19:17 ` Sebastian Herbszt
2013-10-11 6:31 ` Gerd Hoffmann
2013-11-24 20:35 ` Brad Smith
2013-11-25 7:02 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358705534.20334.53.camel@shinybook.infradead.org \
--to=dwmw2@infradead.org \
--cc=info@vruppert.de \
--cc=qemu-devel@nongnu.org \
--cc=vgabios-developers@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).