From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, afaerber@suse.de
Subject: [Qemu-devel] [PATCH v2 09/12] qdev: inline object_delete into qbus_free/qdev_free
Date: Mon, 21 Jan 2013 13:30:19 +0100 [thread overview]
Message-ID: <1358771422-14282-10-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1358771422-14282-1-git-send-email-pbonzini@redhat.com>
We want object_delete to disappear, and we will do this one class at a
time. Inline it for the qdev case, which we will tackle first.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/qdev.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index 24bb19a..e65b32f 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -267,7 +267,8 @@ void qdev_init_nofail(DeviceState *dev)
/* Unlink device from bus and free the structure. */
void qdev_free(DeviceState *dev)
{
- object_delete(OBJECT(dev));
+ object_unparent(OBJECT(dev));
+ object_unref(OBJECT(dev));
}
void qdev_machine_creation_done(void)
@@ -472,7 +473,8 @@ BusState *qbus_create(const char *typename, DeviceState *parent, const char *nam
void qbus_free(BusState *bus)
{
- object_delete(OBJECT(bus));
+ object_unparent(OBJECT(bus));
+ object_unref(OBJECT(bus));
}
static char *bus_get_fw_dev_path(BusState *bus, DeviceState *dev)
--
1.8.1
next prev parent reply other threads:[~2013-01-21 12:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 12:30 [Qemu-devel] [PATCH v2 00/12] qdev: correct reference counting Paolo Bonzini
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 01/12] qdev: export and use qbus_init Paolo Bonzini
2013-01-21 13:01 ` Andreas Färber
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 02/12] qdev: use object_new, not g_malloc to create buses Paolo Bonzini
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 03/12] qom: preserve object while unparenting it Paolo Bonzini
2013-01-21 13:03 ` Andreas Färber
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 04/12] qom: document reference counting of link properties Paolo Bonzini
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 05/12] qdev: add reference count to a device for the BusChild Paolo Bonzini
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 06/12] qdev: move deletion of children from finalize to unparent Paolo Bonzini
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 07/12] qdev: move unrealization of devices " Paolo Bonzini
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 08/12] qdev: add reference for the bus while it is referred to by the DeviceState Paolo Bonzini
2013-01-21 12:30 ` Paolo Bonzini [this message]
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 11/12] cpu: do not use object_delete Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358771422-14282-10-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).