qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, afaerber@suse.de
Subject: [Qemu-devel] [PATCH v2 11/12] cpu: do not use object_delete
Date: Mon, 21 Jan 2013 13:30:21 +0100	[thread overview]
Message-ID: <1358771422-14282-12-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1358771422-14282-1-git-send-email-pbonzini@redhat.com>

CPUs are never added to the composition tree, so delete is achieved
simply by removing the last references to them.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 linux-user/syscall.c        | 2 +-
 target-i386/helper.c        | 4 ++--
 target-ppc/translate_init.c | 2 +-
 target-sparc/cpu.c          | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 693e66f..a148d9f 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -5202,7 +5202,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
                         NULL, NULL, 0);
           }
           thread_env = NULL;
-          object_delete(OBJECT(ENV_GET_CPU(cpu_env)));
+          object_unref(OBJECT(ENV_GET_CPU(cpu_env)));
           g_free(ts);
           pthread_exit(NULL);
       }
diff --git a/target-i386/helper.c b/target-i386/helper.c
index 547c25e..269549d 100644
--- a/target-i386/helper.c
+++ b/target-i386/helper.c
@@ -1276,14 +1276,14 @@ X86CPU *cpu_x86_init(const char *cpu_model)
     env->cpu_model_str = cpu_model;
 
     if (cpu_x86_register(cpu, cpu_model) < 0) {
-        object_delete(OBJECT(cpu));
+        object_unref(OBJECT(cpu));
         return NULL;
     }
 
     x86_cpu_realize(OBJECT(cpu), &error);
     if (error) {
         error_free(error);
-        object_delete(OBJECT(cpu));
+        object_unref(OBJECT(cpu));
         return NULL;
     }
     return cpu;
diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 2d78529..ee51419 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -10346,7 +10346,7 @@ PowerPCCPU *cpu_ppc_init(const char *cpu_model)
     if (err != NULL) {
         fprintf(stderr, "%s\n", error_get_pretty(err));
         error_free(err);
-        object_delete(OBJECT(cpu));
+        object_unref(OBJECT(cpu));
         return NULL;
     }
 
diff --git a/target-sparc/cpu.c b/target-sparc/cpu.c
index f404aa8..4bc1afc 100644
--- a/target-sparc/cpu.c
+++ b/target-sparc/cpu.c
@@ -119,7 +119,7 @@ SPARCCPU *cpu_sparc_init(const char *cpu_model)
     }
 
     if (cpu_sparc_register(env, cpu_model) < 0) {
-        object_delete(OBJECT(cpu));
+        object_unref(OBJECT(cpu));
         return NULL;
     }
     qemu_init_vcpu(env);
-- 
1.8.1

      parent reply	other threads:[~2013-01-21 12:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-21 12:30 [Qemu-devel] [PATCH v2 00/12] qdev: correct reference counting Paolo Bonzini
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 01/12] qdev: export and use qbus_init Paolo Bonzini
2013-01-21 13:01   ` Andreas Färber
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 02/12] qdev: use object_new, not g_malloc to create buses Paolo Bonzini
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 03/12] qom: preserve object while unparenting it Paolo Bonzini
2013-01-21 13:03   ` Andreas Färber
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 04/12] qom: document reference counting of link properties Paolo Bonzini
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 05/12] qdev: add reference count to a device for the BusChild Paolo Bonzini
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 06/12] qdev: move deletion of children from finalize to unparent Paolo Bonzini
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 07/12] qdev: move unrealization of devices " Paolo Bonzini
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 08/12] qdev: add reference for the bus while it is referred to by the DeviceState Paolo Bonzini
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 09/12] qdev: inline object_delete into qbus_free/qdev_free Paolo Bonzini
2013-01-21 12:30 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358771422-14282-12-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).