qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, afaerber@suse.de
Subject: [Qemu-devel] [PATCH v2 08/12] qdev: add reference for the bus while it is referred to by the DeviceState
Date: Mon, 21 Jan 2013 13:30:18 +0100	[thread overview]
Message-ID: <1358771422-14282-9-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1358771422-14282-1-git-send-email-pbonzini@redhat.com>

Now that the unparent callbacks are complete, we can correctly account
more missing references.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/qdev.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/qdev.c b/hw/qdev.c
index aad360f..24bb19a 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -100,6 +100,7 @@ static void bus_add_child(BusState *bus, DeviceState *child)
 void qdev_set_parent_bus(DeviceState *dev, BusState *bus)
 {
     dev->parent_bus = bus;
+    object_ref(OBJECT(bus));
     bus_add_child(bus, dev);
 }
 
@@ -773,6 +774,8 @@ static void device_unparent(Object *obj)
     }
     if (dev->parent_bus) {
         bus_remove_child(dev->parent_bus, dev);
+        object_unref(OBJECT(dev->parent_bus));
+        dev->parent_bus = NULL;
     }
 }
 
-- 
1.8.1

  parent reply	other threads:[~2013-01-21 12:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-21 12:30 [Qemu-devel] [PATCH v2 00/12] qdev: correct reference counting Paolo Bonzini
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 01/12] qdev: export and use qbus_init Paolo Bonzini
2013-01-21 13:01   ` Andreas Färber
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 02/12] qdev: use object_new, not g_malloc to create buses Paolo Bonzini
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 03/12] qom: preserve object while unparenting it Paolo Bonzini
2013-01-21 13:03   ` Andreas Färber
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 04/12] qom: document reference counting of link properties Paolo Bonzini
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 05/12] qdev: add reference count to a device for the BusChild Paolo Bonzini
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 06/12] qdev: move deletion of children from finalize to unparent Paolo Bonzini
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 07/12] qdev: move unrealization of devices " Paolo Bonzini
2013-01-21 12:30 ` Paolo Bonzini [this message]
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 09/12] qdev: inline object_delete into qbus_free/qdev_free Paolo Bonzini
2013-01-21 12:30 ` [Qemu-devel] [PATCH v2 11/12] cpu: do not use object_delete Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358771422-14282-9-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).