From: Jason Wang <jasowang@redhat.com>
To: aliguori@us.ibm.com, mst@redhat.com, qemu-devel@nongnu.org,
blauwirbel@gmail.com, shajnocz@redhat.com
Cc: krkumar2@in.ibm.com, kvm@vger.kernel.org, mprivozn@redhat.com,
Jason Wang <jasowang@redhat.com>,
rusty@rustcorp.com.au, jwhan@filewood.snu.ac.kr,
gaowanlong@cn.fujitsu.com
Subject: [Qemu-devel] [PATCH V4 RESEND 07/22] net: introduce qemu_net_client_setup()
Date: Fri, 1 Feb 2013 15:39:41 +0800 [thread overview]
Message-ID: <1359704396-55327-8-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1359704396-55327-1-git-send-email-jasowang@redhat.com>
This patch separates the setup of NetClientState from its allocation, this will
allow allocating an arrays of NetClientState and does the initialization one by
one which is what multiqueue needs.
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
net/net.c | 29 +++++++++++++++++++----------
1 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/net/net.c b/net/net.c
index 16dd327..3a5bdf6 100644
--- a/net/net.c
+++ b/net/net.c
@@ -182,17 +182,12 @@ static char *assign_name(NetClientState *nc1, const char *model)
return g_strdup(buf);
}
-NetClientState *qemu_new_net_client(NetClientInfo *info,
- NetClientState *peer,
- const char *model,
- const char *name)
+static void qemu_net_client_setup(NetClientState *nc,
+ NetClientInfo *info,
+ NetClientState *peer,
+ const char *model,
+ const char *name)
{
- NetClientState *nc;
-
- assert(info->size >= sizeof(NetClientState));
-
- nc = g_malloc0(info->size);
-
nc->info = info;
nc->model = g_strdup(model);
if (name) {
@@ -210,6 +205,20 @@ NetClientState *qemu_new_net_client(NetClientInfo *info,
nc->send_queue = qemu_new_net_queue(nc);
+}
+
+NetClientState *qemu_new_net_client(NetClientInfo *info,
+ NetClientState *peer,
+ const char *model,
+ const char *name)
+{
+ NetClientState *nc;
+
+ assert(info->size >= sizeof(NetClientState));
+
+ nc = g_malloc0(info->size);
+ qemu_net_client_setup(nc, info, peer, model, name);
+
return nc;
}
--
1.7.1
next prev parent reply other threads:[~2013-02-01 7:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 7:39 [Qemu-devel] [PATCH V4 RESEND 00/22] Multiqueue virtio-net Jason Wang
2013-02-01 7:39 ` [Qemu-devel] [PATCH V4 RESEND 01/22] net: tap: using bool instead of bitfield Jason Wang
2013-02-01 7:39 ` [Qemu-devel] [PATCH V4 RESEND 02/22] net: tap: use abort() instead of assert(0) Jason Wang
2013-02-01 7:39 ` [Qemu-devel] [PATCH V4 RESEND 03/22] net: introduce qemu_get_queue() Jason Wang
2013-02-01 7:39 ` [Qemu-devel] [PATCH V4 RESEND 04/22] net: introduce qemu_get_nic() Jason Wang
2013-02-01 7:39 ` [Qemu-devel] [PATCH V4 RESEND 05/22] net: intorduce qemu_del_nic() Jason Wang
2013-02-01 18:00 ` Eric Blake
2013-02-01 7:39 ` [Qemu-devel] [PATCH V4 RESEND 06/22] net: introduce qemu_find_net_clients_except() Jason Wang
2013-02-01 7:39 ` Jason Wang [this message]
2013-02-01 7:39 ` [Qemu-devel] [PATCH V4 RESEND 08/22] net: introduce NetClientState destructor Jason Wang
2013-02-01 7:39 ` [Qemu-devel] [PATCH V4 RESEND 09/22] net: multiqueue support Jason Wang
2013-02-01 7:39 ` [Qemu-devel] [PATCH V4 RESEND 10/22] tap: import linux multiqueue constants Jason Wang
2013-02-01 7:39 ` [Qemu-devel] [PATCH V4 RESEND 11/22] tap: factor out common tap initialization Jason Wang
2013-02-01 7:39 ` [Qemu-devel] [PATCH V4 RESEND 12/22] tap: add Linux multiqueue support Jason Wang
2013-02-01 7:39 ` [Qemu-devel] [PATCH V4 RESEND 13/22] tap: support enabling or disabling a queue Jason Wang
2013-02-01 7:39 ` [Qemu-devel] [PATCH V4 RESEND 14/22] tap: introduce a helper to get the name of an interface Jason Wang
2013-02-01 7:39 ` [Qemu-devel] [PATCH V4 RESEND 15/22] tap: multiqueue support Jason Wang
2013-02-01 22:43 ` Eric Blake
2013-02-01 7:39 ` [Qemu-devel] [PATCH V4 RESEND 17/22] virtio: introduce virtio_del_queue() Jason Wang
2013-02-01 7:39 ` [Qemu-devel] [PATCH V4 RESEND 18/22] virtio: add a queue_index to VirtQueue Jason Wang
2013-02-01 7:39 ` [Qemu-devel] [PATCH V4 RESEND 19/22] virtio-net: separate virtqueue from VirtIONet Jason Wang
2013-02-01 7:39 ` [Qemu-devel] [PATCH V4 RESEND 20/22] virtio-net: multiqueue support Jason Wang
2013-02-01 7:39 ` [Qemu-devel] [PATCH V4 RESEND 21/22] virtio-net: migration support for multiqueue Jason Wang
2013-02-01 7:39 ` [Qemu-devel] [PATCH V4 RESEND 22/22] virtio-net: compat multiqueue support Jason Wang
2013-02-01 8:22 ` [Qemu-devel] [PATCH V4 RESEND 00/22] Multiqueue virtio-net Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359704396-55327-8-git-send-email-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=gaowanlong@cn.fujitsu.com \
--cc=jwhan@filewood.snu.ac.kr \
--cc=krkumar2@in.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mprivozn@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=shajnocz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).