qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: lcapitulino@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 0/7] propagate Errors to do_device_add()
Date: Fri,  1 Feb 2013 18:38:12 +0100	[thread overview]
Message-ID: <1359740299-27968-1-git-send-email-lersek@redhat.com> (raw)

This series is the first in converting do_device_add() to qapi.

The following call chains have been modified:

  do_device_add -> qemu_find_opts -> error_report
  do_device_add -> qdev_device_add -> qerror_report
  do_device_add -> qdev_device_add -> qbus_find -> qbus_find_recursive -> qerror_report
  do_device_add -> qdev_device_add -> qbus_find -> qerror_report
  do_device_add -> qdev_device_add -> set_property -> qdev_prop_parse -> qerror_report_err

The following call chains
- all depend on !monitor_cur_is_qmp() at some level (marked with *),
- all print informative messages (not errors per se),
- are the next step in the conversion -- ultimately they belong in HMP:

  do_device_add -> qemu_opts_from_qdict -> qemu_opts_create -> error_printf_unless_qmp*
  do_device_add -> qemu_opts_from_qdict -> qemu_opts_from_qdict_1 -> qemu_opt_set_err -> opt_set -> qemu_opt_parse -> parse_option_size -> error_printf_unless_qmp*
  do_device_add* -> qdev_device_help -> qdev_print_devinfo -> error_printf
  do_device_add* -> qdev_device_help -> error_printf
  do_device_add -> qdev_device_add -> qbus_find* -> qbus_list_dev -> error_printf
  do_device_add -> qdev_device_add -> qbus_find* -> qbus_list_bus -> error_printf

Laszlo Ersek (7):
  remove some trailing whitespace
  do_device_add(): look up "device" opts list with qemu_find_opts_err()
  qdev_prop_parse(): report errors via Error
  qbus_find_recursive(): reorganize
  qbus_find_recursive(): terminate search by name in case of fatal
    error
  qbus_find(): report errors via Error
  qdev_device_add(): report errors with Error

 hw/qdev-monitor.h    |    3 +-
 hw/qdev-properties.h |    4 +-
 hw/qdev-monitor.c    |  124 ++++++++++++++++++++++++++++++--------------------
 hw/qdev-properties.c |   12 +++--
 vl.c                 |   17 ++++--
 5 files changed, 99 insertions(+), 61 deletions(-)

             reply	other threads:[~2013-02-01 17:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-01 17:38 Laszlo Ersek [this message]
2013-02-01 17:38 ` [Qemu-devel] [PATCH 1/7] remove some trailing whitespace Laszlo Ersek
2013-02-01 17:38 ` [Qemu-devel] [PATCH 2/7] do_device_add(): look up "device" opts list with qemu_find_opts_err() Laszlo Ersek
2013-02-01 17:38 ` [Qemu-devel] [PATCH 3/7] qdev_prop_parse(): report errors via Error Laszlo Ersek
2013-02-01 17:38 ` [Qemu-devel] [PATCH 4/7] qbus_find_recursive(): reorganize Laszlo Ersek
2013-02-01 17:38 ` [Qemu-devel] [PATCH 5/7] qbus_find_recursive(): terminate search by name in case of fatal error Laszlo Ersek
2013-02-01 17:38 ` [Qemu-devel] [PATCH 6/7] qbus_find(): report errors via Error Laszlo Ersek
2013-02-01 17:38 ` [Qemu-devel] [PATCH 7/7] qdev_device_add(): report errors with Error Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1359740299-27968-1-git-send-email-lersek@redhat.com \
    --to=lersek@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).