From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1QzO-0007PL-Gz for qemu-devel@nongnu.org; Fri, 01 Feb 2013 19:29:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U1QzN-0005za-9j for qemu-devel@nongnu.org; Fri, 01 Feb 2013 19:29:50 -0500 Received: from e8.ny.us.ibm.com ([32.97.182.138]:52952) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1Qf2-0007cU-Vz for qemu-devel@nongnu.org; Fri, 01 Feb 2013 19:08:49 -0500 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 1 Feb 2013 19:08:48 -0500 Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id A73256E804F for ; Fri, 1 Feb 2013 19:08:29 -0500 (EST) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r1208Vpb288846 for ; Fri, 1 Feb 2013 19:08:31 -0500 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r1208UNN002175 for ; Fri, 1 Feb 2013 19:08:30 -0500 From: Anthony Liguori Date: Fri, 1 Feb 2013 18:08:29 -0600 Message-Id: <1359763709-17712-1-git-send-email-aliguori@us.ibm.com> Subject: [Qemu-devel] [PATCH 1/2] tap: unbreak -netdev tap,fd=X List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , Jason Wang , Bruce Rogers The multiqueue patch series broke -netdev tap,fd=X which manifests as libvirt not being able to start a guest. This was because it passed NULL for the netdev name which results in an anonymous netdev device regardless of what the user specified. Cc: Jason Wang Cc: Bruce Rogers Reported-by: Bruce Rogers Signed-off-by: Anthony Liguori --- net/tap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tap.c b/net/tap.c index 1bf7609..48c254e 100644 --- a/net/tap.c +++ b/net/tap.c @@ -711,7 +711,7 @@ int net_init_tap(const NetClientOptions *opts, const char *name, vnet_hdr = tap_probe_vnet_hdr(fd); - if (net_init_tap_one(tap, peer, "tap", NULL, NULL, + if (net_init_tap_one(tap, peer, "tap", name, NULL, script, downscript, vhostfdname, vnet_hdr, fd)) { return -1; -- 1.8.0