From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1jOK-00017L-5H for qemu-devel@nongnu.org; Sat, 02 Feb 2013 15:08:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U1jOI-0007AN-1Z for qemu-devel@nongnu.org; Sat, 02 Feb 2013 15:08:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35073) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1jOH-00079S-QD for qemu-devel@nongnu.org; Sat, 02 Feb 2013 15:08:45 -0500 Message-ID: <1359835708.1968.3.camel@localhost> From: Vadim Rozenfeld Date: Sun, 03 Feb 2013 07:08:28 +1100 In-Reply-To: <510D09C2.6050905@redhat.com> References: <510C2327.5080707@msgid.tls.msk.ru> <510C25F2.8000406@msgid.tls.msk.ru> <87fw1fbwk7.fsf@codemonkey.ws> <510C28BD.7050701@msgid.tls.msk.ru> <87zjznagbd.fsf@codemonkey.ws> <510D09C2.6050905@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: yvugenfi@redhat.com, Jason Wang Cc: Anthony Liguori , Michael Tokarev , qemu-devel , "Michael S. Tsirkin" On Sat, 2013-02-02 at 20:42 +0800, Jason Wang wrote: > On 02/02/2013 05:13 AM, Anthony Liguori wrote: > > Michael Tokarev writes: > > > >> 02.02.2013 00:36, Anthony Liguori wrote: > >>> Michael Tokarev writes: > >>> > >>>> 02.02.2013 00:18, Michael Tokarev wrote: > >>>>> Just a heads-up for now, no real diagnostics or anything like that. > >>>>> > >>>>> Current git master (a9c87c586ba9ee290792a98dc126b2861b7f8b03), when booted > >>>>> a windows guest, results in no virtio-net inside. Neither winXP nor Win7, > >>>>> neither older nor latest (22 Jan 2013) virtio-net drivers works. > >>>>> > >>>>> Windows displays a yellow exclamation mark near the virtio-net device and > >>>>> says it can't start the device (Code 10). > >>>>> > >>>>> Linux guests work fine, quick test anyway. > >>>>> > >>>>> Cc'ing Jason since his virtio-net changes was last. But I repeat: no > >>>>> diagnostics as of yet, no bisection. > >>>> Bisection was easy, since win works fine right before the multiqueue > >>>> virtio-net series. This is the first bad commit: > >>> Adding Vadim and Michael. > >>> > >>> If you use -M pc-1.3 or explicitly disable multiqueue, does the driver work? > >> Neither one of these nor both makes any visible difference. > >> Neither does -M pc-1.1 (just in case). > > Hrm, then it's very likely not a driver problem. Thanks. > > > > Regards, > > > > Anthony Liguori > > Have a look at this issue. It was caused by multiqueue patch who adds a > new field to virtio_net_cfg. Not sure multiqueue is the root cause since > I also find even w/o multiqueue, adding any new field to virtio_net_cfg > will break windows guest. Haven't had a clue on this, will continue > investigate. cc'ing Yan, our NDIS guy. Thank you, Vadim. > > > >>> Regards, > >>> > >>> Anthony Liguori > >>> > >>>> commit fed699f9ca6ae8a0fb62803334cf46fa64d1eb91 > >>>> Author: Jason Wang > >>>> Date: Wed Jan 30 19:12:39 2013 +0800 > >>>> > >>>> virtio-net: multiqueue support > >>>> > >>>> This patch implements both userspace and vhost support for multiple queue > >>>> virtio-net (VIRTIO_NET_F_MQ). This is done by introducing an array of > >>>> VirtIONetQueue to VirtIONet. > >>>> > >>>> Signed-off-by: Jason Wang > >>>> Signed-off-by: Anthony Liguori > >>>> > >>>> After this commit, win guest (winXP and win7) shows yellow > >>>> exclamation sign and is unable to start the device with > >>>> code 10. > >>>> > >>>> FWIW. I'm not sure it is a good idea to make a release with > >>>> such a breakage, even rc0. > >>>> > >>>> Thanks, > >>>> > >>>> /mjt > > >