qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: qemu-devel@nongnu.org
Cc: Michael Tokarev <mjt@tls.msk.ru>
Subject: [Qemu-devel] [PATCH 0/2] virtio-net: fix config size for older guests
Date: Sat,  2 Feb 2013 17:06:21 -0600	[thread overview]
Message-ID: <1359846384-3771-1-git-send-email-aliguori@us.ibm.com> (raw)

virtio-net multiqueue added a new field to the config layout.  The config
layout is rounded up to the nearest power of 2 and this field caused
field causes the size to go from 8 bytes to 16 bytes.

For reasons unknown, the increase in config size causes the Windows
virtio-net driver to fail.  This is probably a bug in the driver but
it exposes a larger bug in QEMU.

While we disable features for compatibility machines, we always use the
latest config size.  This presents a slightly different machine model
than what we should be exposing.

This series fixes this specific problem such that -M pc-1.3 should work
again with the Windows drivers.  -M pc will still fail.

We need to find a better way to do this but in absence of a nicer approach
this seems likes a good compromise for 1.4.  I think we need to choose
something like the MAX() config size required by all of the enabled host
features.

Besides -M pc-1.3, another work around would be:

  -global virtio-net-pci.mq=off

This should work after this patch series is applied.  We can put this
work around in the release notes as suggested for users of the
virtio-win drivers until they are fixed.

Reported-by: Michael Tokarev <mjt@tls.msk.ru>

FYI: only lightly tested on my end but so far, it seems to work.

             reply	other threads:[~2013-02-02 23:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-02 23:06 Anthony Liguori [this message]
2013-02-02 23:06 ` [Qemu-devel] [PATCH 1/2] virtio-net: pass host features to virtio_net_init Anthony Liguori
2013-02-03  0:12   ` Andreas Färber
2013-02-02 23:06 ` [Qemu-devel] [PATCH 2/2] virtio-net: do not expose a larger config size if multiqueue isn't enabled Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1359846384-3771-1-git-send-email-aliguori@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).