From: Richard Henderson <richard.henderson@linaro.org>
To: Thomas Huth <thuth@redhat.com>,
qemu-s390x@nongnu.org, David Hildenbrand <david@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] target/s390x: Fix emulation of the VISTR instruction
Date: Tue, 11 Oct 2022 10:14:45 -0700 [thread overview]
Message-ID: <1361f358-98b9-3c1b-b80e-016de278aa69@linaro.org> (raw)
In-Reply-To: <20221011101401.81849-1-thuth@redhat.com>
On 10/11/22 03:14, Thomas Huth wrote:
> The element size is encoded in the M3 field, not in the M4
> field. Let's also add a TCG test that shows the failing
> behavior without this fix.
>
> Resolves:https://gitlab.com/qemu-project/qemu/-/issues/1248
> Signed-off-by: Thomas Huth<thuth@redhat.com>
> ---
> tests/tcg/s390x/vf.c | 50 +++++++++++++++++++++++++++++
> target/s390x/tcg/translate_vx.c.inc | 2 +-
> tests/tcg/s390x/Makefile.target | 6 ++++
> 3 files changed, 57 insertions(+), 1 deletion(-)
> create mode 100644 tests/tcg/s390x/vf.c
As far as the translate and contents of the test go:
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2022-10-11 17:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 10:14 [PATCH] target/s390x: Fix emulation of the VISTR instruction Thomas Huth
2022-10-11 12:30 ` David Hildenbrand
2022-10-11 12:45 ` Thomas Huth
2022-10-11 13:24 ` David Hildenbrand
2022-10-11 16:39 ` Richard Henderson
2022-10-11 14:14 ` Alex Bennée
2022-10-11 17:14 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361f358-98b9-3c1b-b80e-016de278aa69@linaro.org \
--to=richard.henderson@linaro.org \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).