From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UBTeK-0007zg-AX for qemu-devel@nongnu.org; Fri, 01 Mar 2013 12:21:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UBTeJ-0001RS-38 for qemu-devel@nongnu.org; Fri, 01 Mar 2013 12:21:36 -0500 Received: from mail-ie0-x22d.google.com ([2607:f8b0:4001:c03::22d]:46407) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UBTeI-0001RI-V3 for qemu-devel@nongnu.org; Fri, 01 Mar 2013 12:21:35 -0500 Received: by mail-ie0-f173.google.com with SMTP id 9so3834052iec.18 for ; Fri, 01 Mar 2013 09:21:33 -0800 (PST) From: peter@gridcentric.ca Date: Fri, 1 Mar 2013 12:21:33 -0500 Message-Id: <1362158493-11907-1-git-send-email-peter@gridcentric.ca> In-Reply-To: <876237ebst.fsf@codemonkey.ws> References: <876237ebst.fsf@codemonkey.ws> Subject: [Qemu-devel] [PATCH v2] exec: make -mem-path filenames deterministic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, aliguori@us.ibm.com Cc: andreslc@gridcentric.ca, peter@gridcentric.ca From: Peter Feiner Adds ramblocks' names to their backing files when using -mem-path. Eases introspection and debugging. Signed-off-by: Peter Feiner --- On Tue, Jan 8, 2013 at 2:04 PM, Anthony Liguori wrote: > > Yes, please submit the oneliner. Here it is :) The commit should probably be called "exec: add ramblocks' names to -mem-path files" since the paths aren't deterministic. v1 -> v2: Just add ramblock name to mkstemp template. Thanks, Peter exec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/exec.c b/exec.c index a41bcb8..16a5452 100644 --- a/exec.c +++ b/exec.c @@ -865,7 +865,8 @@ static void *file_ram_alloc(RAMBlock *block, return NULL; } - filename = g_strdup_printf("%s/qemu_back_mem.XXXXXX", path); + filename = g_strdup_printf("%s/qemu_back_mem.%s.XXXXXX", path, + block->mr->name); fd = mkstemp(filename); if (fd < 0) { -- 1.7.10.4