From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50466)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1UCKaA-0006Hf-Fk
	for qemu-devel@nongnu.org; Sun, 03 Mar 2013 20:52:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1UCKa9-0000XW-Im
	for qemu-devel@nongnu.org; Sun, 03 Mar 2013 20:52:50 -0500
Received: from mx1.redhat.com ([209.132.183.28]:54631)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1UCKa9-0000XR-B1
	for qemu-devel@nongnu.org; Sun, 03 Mar 2013 20:52:49 -0500
Message-ID: <1362361965.2489.2.camel@bling.home>
From: Alex Williamson <alex.williamson@redhat.com>
Date: Sun, 03 Mar 2013 18:52:45 -0700
In-Reply-To: <CAFEAcA-it7SJDgTh09fUiaVTbEig=WBsbXh=jm-+AghC+DDCkA@mail.gmail.com>
References: <20130303171901.15425.61733.stgit@bling.home>
	<20130303172132.15425.15034.stgit@bling.home>
	<CAFEAcA-it7SJDgTh09fUiaVTbEig=WBsbXh=jm-+AghC+DDCkA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 2/2] pci: Teach PCI Bridges about VGA
 routing
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, mst@redhat.com

On Mon, 2013-03-04 at 09:39 +0800, Peter Maydell wrote:
> On 4 March 2013 01:21, Alex Williamson <alex.williamson@redhat.com> wrote:
> > --- a/hw/pci/pcie_port.c
> > +++ b/hw/pci/pcie_port.c
> > @@ -28,10 +28,12 @@ void pcie_port_init_reg(PCIDevice *d)
> >      pci_set_word(d->config + PCI_SEC_STATUS, 0);
> >
> >      /* Unlike conventional pci bridge, some bits are hardwired to 0. */
> > +#define  PCI_BRIDGE_CTL_VGA_16BIT       0x10    /* VGA 16-bit decode */
> 
> Shouldn't this #define be in pci_regs.h with the other PCI_BRIDGE_CTL_*
> constants?

See the existing define in pci.c.  pci_regs.h is derived from the Linux
kernel header, which is not 100% complete.  Ideally it would contain
this, but it doesn't currently so I'm following the existing example.
Thanks,

Alex

> >      pci_set_word(d->wmask + PCI_BRIDGE_CONTROL,
> >                   PCI_BRIDGE_CTL_PARITY |
> >                   PCI_BRIDGE_CTL_ISA |
> >                   PCI_BRIDGE_CTL_VGA |
> > +                 PCI_BRIDGE_CTL_VGA_16BIT | /* Req, but no alias support yet */
> >                   PCI_BRIDGE_CTL_SERR |
> >                   PCI_BRIDGE_CTL_BUS_RESET);
> >  }
> 
> thanks
> -- PMM