* [Qemu-devel] [PATCH] lm32: remove unused function
@ 2013-03-04 17:11 Paolo Bonzini
2013-03-04 20:59 ` Michael Walle
2013-03-08 9:18 ` Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Paolo Bonzini @ 2013-03-04 17:11 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, michael
The milkymist-minimac device in fact does not exist at all.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/milkymist-hw.h | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/hw/milkymist-hw.h b/hw/milkymist-hw.h
index c8bd7e9..5def311 100644
--- a/hw/milkymist-hw.h
+++ b/hw/milkymist-hw.h
@@ -170,22 +170,6 @@ static inline DeviceState *milkymist_ac97_create(hwaddr base,
return dev;
}
-static inline DeviceState *milkymist_minimac_create(hwaddr base,
- qemu_irq rx_irq, qemu_irq tx_irq)
-{
- DeviceState *dev;
-
- qemu_check_nic_model(&nd_table[0], "minimac");
- dev = qdev_create(NULL, "milkymist-minimac");
- qdev_set_nic_properties(dev, &nd_table[0]);
- qdev_init_nofail(dev);
- sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, base);
- sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, rx_irq);
- sysbus_connect_irq(SYS_BUS_DEVICE(dev), 1, tx_irq);
-
- return dev;
-}
-
static inline DeviceState *milkymist_minimac2_create(hwaddr base,
hwaddr buffers_base, qemu_irq rx_irq, qemu_irq tx_irq)
{
--
1.8.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] lm32: remove unused function
2013-03-04 17:11 [Qemu-devel] [PATCH] lm32: remove unused function Paolo Bonzini
@ 2013-03-04 20:59 ` Michael Walle
2013-03-08 9:18 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Michael Walle @ 2013-03-04 20:59 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-trivial, michael, qemu-devel
On Mon, March 4, 2013 18:11, Paolo Bonzini wrote:
> The milkymist-minimac device in fact does not exist at all.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: Michael Walle <michael@walle.cc>
> ---
> hw/milkymist-hw.h | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/hw/milkymist-hw.h b/hw/milkymist-hw.h
> index c8bd7e9..5def311 100644
> --- a/hw/milkymist-hw.h
> +++ b/hw/milkymist-hw.h
> @@ -170,22 +170,6 @@ static inline DeviceState
> *milkymist_ac97_create(hwaddr base,
> return dev;
> }
>
> -static inline DeviceState *milkymist_minimac_create(hwaddr base,
> - qemu_irq rx_irq, qemu_irq tx_irq)
> -{
> - DeviceState *dev;
> -
> - qemu_check_nic_model(&nd_table[0], "minimac");
> - dev = qdev_create(NULL, "milkymist-minimac");
> - qdev_set_nic_properties(dev, &nd_table[0]);
> - qdev_init_nofail(dev);
> - sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, base);
> - sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, rx_irq);
> - sysbus_connect_irq(SYS_BUS_DEVICE(dev), 1, tx_irq);
> -
> - return dev;
> -}
> -
> static inline DeviceState *milkymist_minimac2_create(hwaddr base,
> hwaddr buffers_base, qemu_irq rx_irq, qemu_irq tx_irq)
> {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] lm32: remove unused function
2013-03-04 17:11 [Qemu-devel] [PATCH] lm32: remove unused function Paolo Bonzini
2013-03-04 20:59 ` Michael Walle
@ 2013-03-08 9:18 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2013-03-08 9:18 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-trivial, michael, qemu-devel
On Mon, Mar 04, 2013 at 06:11:47PM +0100, Paolo Bonzini wrote:
> The milkymist-minimac device in fact does not exist at all.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/milkymist-hw.h | 16 ----------------
> 1 file changed, 16 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-08 9:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-04 17:11 [Qemu-devel] [PATCH] lm32: remove unused function Paolo Bonzini
2013-03-04 20:59 ` Michael Walle
2013-03-08 9:18 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).