qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Aurelien Jarno <aurelien@aurel32.net>, Blue Swirl <blauwirbel@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>
Subject: [Qemu-devel] [PATCH 02/13] target-arm: Don't decode RFE or SRS on M profile cores
Date: Tue,  5 Mar 2013 01:12:00 +0000	[thread overview]
Message-ID: <1362445931-4383-3-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1362445931-4383-1-git-send-email-peter.maydell@linaro.org>

M profile cores do not have the RFE or SRS instructions, so
correctly UNDEF these insn patterns on those cores.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target-arm/translate.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/target-arm/translate.c b/target-arm/translate.c
index e16c113..35a21be 100644
--- a/target-arm/translate.c
+++ b/target-arm/translate.c
@@ -8180,9 +8180,10 @@ static int disas_thumb2_insn(CPUARMState *env, DisasContext *s, uint16_t insn_hw
         } else {
             /* Load/store multiple, RFE, SRS.  */
             if (((insn >> 23) & 1) == ((insn >> 24) & 1)) {
-                /* Not available in user mode.  */
-                if (IS_USER(s))
+                /* RFE, SRS: not available in user mode or on M profile */
+                if (IS_USER(s) || IS_M(env)) {
                     goto illegal_op;
+                }
                 if (insn & (1 << 20)) {
                     /* rfe */
                     addr = load_reg(s, rn);
-- 
1.7.9.5

  parent reply	other threads:[~2013-03-05  1:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-05  1:11 [Qemu-devel] [PULL 00/13] target-arm queue (feat.ARM KVM support) Peter Maydell
2013-03-05  1:11 ` [Qemu-devel] [PATCH 01/13] target-arm: Factor out handling of SRS instruction Peter Maydell
2013-03-05  1:12 ` Peter Maydell [this message]
2013-03-05  1:12 ` [Qemu-devel] [PATCH 03/13] oslib-posix: Align to permit transparent hugepages on ARM Linux Peter Maydell
2013-03-05  1:12 ` [Qemu-devel] [PATCH 04/13] linux-headers: resync from mainline to add ARM KVM headers Peter Maydell
2013-03-05  1:12 ` [Qemu-devel] [PATCH 05/13] target-arm: Drop CPUARMState* argument from bank_number() Peter Maydell
2013-03-05  1:12 ` [Qemu-devel] [PATCH 06/13] ARM: KVM: Add support for KVM on ARM architecture Peter Maydell
2013-03-05  1:12 ` [Qemu-devel] [PATCH 07/13] ARM KVM: save and load VFP registers from kernel Peter Maydell
2013-03-05  1:12 ` [Qemu-devel] [PATCH 08/13] hw/arm_gic: Add presave/postload hooks Peter Maydell
2013-03-05  1:12 ` [Qemu-devel] [PATCH 09/13] hw/arm_gic: Convert ARM GIC classes to use init/realize Peter Maydell
2013-03-05  1:12 ` [Qemu-devel] [PATCH 10/13] target-arm: Use MemoryListener to identify GIC base address for KVM Peter Maydell
2013-03-05  1:12 ` [Qemu-devel] [PATCH 11/13] hw/kvm/arm_gic: Implement support for KVM in-kernel ARM GIC Peter Maydell
2013-03-05  1:12 ` [Qemu-devel] [PATCH 12/13] configure: Enable KVM on ARM Peter Maydell
2013-03-05  1:12 ` [Qemu-devel] [PATCH 13/13] MAINTAINERS: add entry for ARM KVM guest cores Peter Maydell
2013-03-05 14:19 ` [Qemu-devel] [PULL 00/13] target-arm queue (feat.ARM KVM support) Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1362445931-4383-3-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=aliguori@us.ibm.com \
    --cc=aurelien@aurel32.net \
    --cc=blauwirbel@gmail.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).