qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: agraf@suse.de
Cc: David Gibson <david@gibson.dropbear.id.au>,
	qemu-ppc@nongnu.org, afaerber@suse.de, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 03/45] target-ppc: Remove address check for logging
Date: Wed,  6 Mar 2013 14:43:51 +1100	[thread overview]
Message-ID: <1362541473-4365-4-git-send-email-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <1362541473-4365-1-git-send-email-david@gibson.dropbear.id.au>

One LOG_MMU statement in mmu_helper.c has an odd check on the effective
address being translated.  I can see no reason for this; I suspect it was
a debugging hack from long ago.  This patch removes it.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 target-ppc/mmu_helper.c |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/target-ppc/mmu_helper.c b/target-ppc/mmu_helper.c
index 3570e91..f1de84c 100644
--- a/target-ppc/mmu_helper.c
+++ b/target-ppc/mmu_helper.c
@@ -906,12 +906,10 @@ static inline int get_segment(CPUPPCState *env, mmu_ctx_t *ctx,
                 ret = find_pte(env, ctx, 0, rw, type, target_page_bits);
                 if (ret < 0) {
                     /* Secondary table lookup */
-                    if (eaddr != 0xEFFFFFFF) {
-                        LOG_MMU("1 htab=" TARGET_FMT_plx "/" TARGET_FMT_plx
-                                " vsid=" TARGET_FMT_lx " api=" TARGET_FMT_lx
-                                " hash=" TARGET_FMT_plx "\n", env->htab_base,
-                                env->htab_mask, vsid, ctx->ptem, ctx->hash[1]);
-                    }
+                    LOG_MMU("1 htab=" TARGET_FMT_plx "/" TARGET_FMT_plx
+                            " vsid=" TARGET_FMT_lx " api=" TARGET_FMT_lx
+                            " hash=" TARGET_FMT_plx "\n", env->htab_base,
+                            env->htab_mask, vsid, ctx->ptem, ctx->hash[1]);
                     ret2 = find_pte(env, ctx, 1, rw, type,
                                     target_page_bits);
                     if (ret2 != -1) {
-- 
1.7.10.4

  parent reply	other threads:[~2013-03-06  3:45 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-06  3:43 [Qemu-devel] [0/45] ppc: Clean up hash mmu implementation David Gibson
2013-03-06  3:43 ` [Qemu-devel] [PATCH 01/45] target-ppc: Remove vestigial PowerPC 620 support David Gibson
2013-03-06  3:43 ` [Qemu-devel] [PATCH 02/45] target-ppc: Trivial cleanups in mmu_helper.c David Gibson
2013-03-06  3:43 ` David Gibson [this message]
2013-03-06  3:43 ` [Qemu-devel] [PATCH 04/45] target-ppc: Move SLB handling into a mmu-hash64.c David Gibson
2013-03-06  3:43 ` [Qemu-devel] [PATCH 05/45] target-ppc: Disentangle pte_check() David Gibson
2013-03-06  3:43 ` [Qemu-devel] [PATCH 06/45] target-ppc: Disentangle find_pte() David Gibson
2013-03-06  3:43 ` [Qemu-devel] [PATCH 07/45] target-ppc: Disentangle get_segment() David Gibson
2013-03-06  3:43 ` [Qemu-devel] [PATCH 08/45] target-ppc: Rework get_physical_address() David Gibson
2013-03-06  3:43 ` [Qemu-devel] [PATCH 09/45] target-ppc: Disentangle get_physical_address() paths David Gibson
2013-03-06  3:43 ` [Qemu-devel] [PATCH 10/45] target-ppc: Disentangle hash mmu paths for cpu_ppc_handle_mmu_fault David Gibson
2013-03-06  3:43 ` [Qemu-devel] [PATCH 11/45] target-ppc: Disentangle hash mmu versions of cpu_get_phys_page_debug() David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 12/45] target-ppc: Disentangle hash mmu helper functions David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 13/45] target-ppc: Don't share get_pteg_offset() between 32 and 64-bit David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 14/45] target-ppc: Disentangle BAT code for 32-bit hash MMUs David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 15/45] target-ppc: mmu_ctx_t should not be a global type David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 16/45] mmu-hash*: Add header file for definitions David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 17/45] mmu-hash*: Add hash pte load/store helpers David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 18/45] mmu-hash*: Reduce use of access_type David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 19/45] mmu-hash64: Remove nx from mmu_ctx_hash64 David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 20/45] mmu-hash*: Remove eaddr field from mmu_ctx_hash{32, 64} David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 21/45] mmu-hash*: Combine ppc_hash{32, 64}_get_physical_address and get_segment{32, 64}() David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 22/45] mmu-hash32: Split out handling of direct store segments David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 23/45] mmu-hash32: Split direct store segment handling into a helper David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 24/45] mmu-hash*: Cleanup segment-level NX check David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 25/45] mmu-hash*: Don't keep looking for PTEs after we find a match David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 26/45] mmu-hash*: Separate PTEG searching from permissions checking David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 27/45] mmu-hash*: Make find_pte{32, 64} do more of the job of finding ptes David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 28/45] mmu-hash*: Remove permission checking from find_pte{32, 64}() David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 29/45] mmu-hash64: Clean up ppc_hash64_htab_lookup() David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 30/45] mmu-hash*: Fold pte_check*() logic into caller David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 31/45] mmu-hash32: Remove odd pointer usage from BAT code David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 32/45] mmu-hash32: Split BAT size logic from permissions logic David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 33/45] mmu-hash32: Clean up BAT matching logic David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 34/45] mmu-hash32: Cleanup BAT lookup David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 35/45] mmu-hash32: Don't look up page tables on BAT permission error David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 36/45] mmu-hash*: Don't update PTE flags when permission is denied David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 37/45] mmu-hash32: Remove nx from context structure David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 38/45] mmu-hash*: Clean up permission checking David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 39/45] mmu-hash64: Factor SLB N bit into permissions bits David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 40/45] mmu-hash*: Clean up PTE flags update David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 41/45] mmu-hash*: Clean up real address calculation David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 42/45] mmu-hash*: Correctly mask RPN from hash PTE David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 43/45] mmu-hash*: Don't use full ppc_hash{32, 64}_translate() path for get_phys_page_debug() David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 44/45] mmu-hash*: Merge translate and fault handling functions David Gibson
2013-03-06  3:44 ` [Qemu-devel] [PATCH 45/45] mmu-hash64: Implement Virtual Page Class Key Protection David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1362541473-4365-4-git-send-email-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).