From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Anthony Liguori <aliguori@us.ibm.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 7/8] pci_host: Drop write-only address_space field
Date: Fri, 8 Mar 2013 13:21:34 +0100 [thread overview]
Message-ID: <1362745295-16398-8-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1362745295-16398-1-git-send-email-stefanha@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
The address_space field of PCIHostState was only ever written, never used.
Drop it completely.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
hw/pci/pci_host.h | 1 -
hw/piix_pci.c | 1 -
hw/ppc/prep.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/hw/pci/pci_host.h b/hw/pci/pci_host.h
index 1845d4d..236cd0f 100644
--- a/hw/pci/pci_host.h
+++ b/hw/pci/pci_host.h
@@ -40,7 +40,6 @@ struct PCIHostState {
MemoryRegion conf_mem;
MemoryRegion data_mem;
MemoryRegion mmcfg;
- MemoryRegion *address_space;
uint32_t config_reg;
PCIBus *bus;
};
diff --git a/hw/piix_pci.c b/hw/piix_pci.c
index 6c77e49..9246983 100644
--- a/hw/piix_pci.c
+++ b/hw/piix_pci.c
@@ -244,7 +244,6 @@ static PCIBus *i440fx_common_init(const char *device_name,
dev = qdev_create(NULL, "i440FX-pcihost");
s = PCI_HOST_BRIDGE(dev);
- s->address_space = address_space_mem;
b = pci_bus_new(dev, NULL, pci_address_space,
address_space_io, 0);
s->bus = b;
diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
index e06dded..2920911 100644
--- a/hw/ppc/prep.c
+++ b/hw/ppc/prep.c
@@ -567,7 +567,6 @@ static void ppc_prep_init(QEMUMachineInitArgs *args)
dev = qdev_create(NULL, "raven-pcihost");
pcihost = PCI_HOST_BRIDGE(dev);
- pcihost->address_space = get_system_memory();
object_property_add_child(qdev_get_machine(), "raven", OBJECT(dev), NULL);
qdev_init_nofail(dev);
pci_bus = (PCIBus *)qdev_get_child_bus(dev, "pci.0");
--
1.8.1.4
next prev parent reply other threads:[~2013-03-08 12:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 12:21 [Qemu-devel] [PULL v2 0/8] Trivial patches for 22 February to 8 March 2013 Stefan Hajnoczi
2013-03-08 12:21 ` [Qemu-devel] [PATCH 1/8] configure: Create link to icon bitmap for out-of-tree builds Stefan Hajnoczi
2013-03-08 12:21 ` [Qemu-devel] [PATCH 2/8] rtc-test: Fix test failures with recent glib Stefan Hajnoczi
2013-03-08 12:21 ` [Qemu-devel] [PATCH 3/8] lm32: remove unused function Stefan Hajnoczi
2013-03-08 12:21 ` [Qemu-devel] [PATCH 4/8] osdep: replace setsockopt by qemu_setsockopt Stefan Hajnoczi
2013-03-08 12:21 ` [Qemu-devel] [PATCH 5/8] configure: Require at least spice-protocol-0.12.3 Stefan Hajnoczi
2013-03-08 12:21 ` [Qemu-devel] [PATCH 6/8] rng-random: Use qemu_open / qemu_close Stefan Hajnoczi
2013-03-08 12:21 ` Stefan Hajnoczi [this message]
2013-03-08 12:21 ` [Qemu-devel] [PATCH 8/8] Fix the wrong description in qemu manual Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362745295-16398-8-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).