From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35337) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDwJH-0005qS-EH for qemu-devel@nongnu.org; Fri, 08 Mar 2013 07:22:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDwJA-0004Ab-RT for qemu-devel@nongnu.org; Fri, 08 Mar 2013 07:22:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:21472) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDwJA-0004AT-Iq for qemu-devel@nongnu.org; Fri, 08 Mar 2013 07:21:56 -0500 From: Stefan Hajnoczi Date: Fri, 8 Mar 2013 13:21:34 +0100 Message-Id: <1362745295-16398-8-git-send-email-stefanha@redhat.com> In-Reply-To: <1362745295-16398-1-git-send-email-stefanha@redhat.com> References: <1362745295-16398-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH 7/8] pci_host: Drop write-only address_space field List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Anthony Liguori , Stefan Hajnoczi From: Peter Maydell The address_space field of PCIHostState was only ever written, never used. Drop it completely. Signed-off-by: Peter Maydell Reviewed-by: Andreas F=C3=A4rber Signed-off-by: Stefan Hajnoczi --- hw/pci/pci_host.h | 1 - hw/piix_pci.c | 1 - hw/ppc/prep.c | 1 - 3 files changed, 3 deletions(-) diff --git a/hw/pci/pci_host.h b/hw/pci/pci_host.h index 1845d4d..236cd0f 100644 --- a/hw/pci/pci_host.h +++ b/hw/pci/pci_host.h @@ -40,7 +40,6 @@ struct PCIHostState { MemoryRegion conf_mem; MemoryRegion data_mem; MemoryRegion mmcfg; - MemoryRegion *address_space; uint32_t config_reg; PCIBus *bus; }; diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 6c77e49..9246983 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -244,7 +244,6 @@ static PCIBus *i440fx_common_init(const char *device_= name, =20 dev =3D qdev_create(NULL, "i440FX-pcihost"); s =3D PCI_HOST_BRIDGE(dev); - s->address_space =3D address_space_mem; b =3D pci_bus_new(dev, NULL, pci_address_space, address_space_io, 0); s->bus =3D b; diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c index e06dded..2920911 100644 --- a/hw/ppc/prep.c +++ b/hw/ppc/prep.c @@ -567,7 +567,6 @@ static void ppc_prep_init(QEMUMachineInitArgs *args) =20 dev =3D qdev_create(NULL, "raven-pcihost"); pcihost =3D PCI_HOST_BRIDGE(dev); - pcihost->address_space =3D get_system_memory(); object_property_add_child(qdev_get_machine(), "raven", OBJECT(dev), = NULL); qdev_init_nofail(dev); pci_bus =3D (PCIBus *)qdev_get_child_bus(dev, "pci.0"); --=20 1.8.1.4