[Qemu-devel] [PULL 0/5] s390 patch queue 2013-03-08

[Qemu-devel] [PULL 0/5] s390 patch queue 2013-03-08

[Alexander Graf]

Hi Blue / Aurelien,

This is my current patch queue for s390.  Please pull.

Alex


The following changes since commit 0bc472a9d6b80567c212023c5eae413f4dfb53ad:
  Kuo-Jung Su (1):
        hw/nand.c: correct the sense of the BUSY/READY status bit

are available in the git repository at:

  git://github.com/agraf/qemu.git s390-for-upstream

Christian Borntraeger (4):
      s390: simplify kvm cpu init
      Allow virtio-net features for legacy s390 virtio bus
      s390/css: Fix subchannel detection
      s390/virtio-ccw: remove redundant call to blockdev_mark_auto_del

Cornelia Huck (1):
      s390: virtio-ccw maintainer

 MAINTAINERS                |   14 ++++++++++++++
 hw/s390x/css.c             |   11 +++++++----
 hw/s390x/s390-virtio-bus.c |    1 +
 hw/s390x/virtio-ccw.c      |    1 -
 target-s390x/cpu.h         |    2 +-
 target-s390x/ioinst.c      |    2 +-
 target-s390x/kvm.c         |    9 ++-------
 7 files changed, 26 insertions(+), 14 deletions(-)

[Qemu-devel] [PATCH 1/5] s390: simplify kvm cpu init

[Alexander Graf]

From: Christian Borntraeger <borntraeger@de.ibm.com>

There is no special code right now and the reset ioctl is done later
on in the the reset handler anyway. Lets simplify the cpu init.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
 target-s390x/kvm.c |    9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c
index 3929771..8f111ae 100644
--- a/target-s390x/kvm.c
+++ b/target-s390x/kvm.c
@@ -103,13 +103,8 @@ unsigned long kvm_arch_vcpu_id(CPUState *cpu)
 
 int kvm_arch_init_vcpu(CPUState *cpu)
 {
-    int ret = 0;
-
-    if (kvm_vcpu_ioctl(cpu, KVM_S390_INITIAL_RESET, NULL) < 0) {
-        perror("cannot init reset vcpu");
-    }
-
-    return ret;
+    /* nothing todo yet */
+    return 0;
 }
 
 void kvm_arch_reset_vcpu(CPUState *cpu)
-- 
1.6.0.2

[Qemu-devel] [PATCH 2/5] s390: virtio-ccw maintainer

[Alexander Graf]

From: Cornelia Huck <cornelia.huck@de.ibm.com>

Add myself as maintainer for virtio-ccw and the s390-ccw-virtio machine.

Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
[agraf: add myself for virtio-ccw machine]
Signed-off-by: Alexander Graf <agraf@suse.de>
---
 MAINTAINERS |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 2439614..0ca7e1d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -454,6 +454,14 @@ M: Alexander Graf <agraf@suse.de>
 S: Maintained
 F: hw/s390-*.c
 
+S390 Virtio-ccw
+M: Cornelia Huck <cornelia.huck@de.ibm.com>
+M: Alexander Graf <agraf@suse.de>
+S: Supported
+F: hw/s390x/s390-virtio-ccw.c
+F: hw/s390x/css.[hc]
+T: git git://github.com/cohuck/qemu virtio-ccw-upstr
+
 UniCore32 Machines
 -------------
 PKUnity-3 SoC initramfs-with-busybox
@@ -565,6 +573,12 @@ M: Stefan Hajnoczi <stefanha@redhat.com>
 S: Supported
 F: hw/virtio-blk*
 
+virtio-ccw
+M: Cornelia Huck <cornelia.huck@de.ibm.com>
+S: Supported
+F: hw/s390x/virtio-ccw.[hc]
+T: git git://github.com/cohuck/qemu virtio-ccw-upstr
+
 virtio-serial
 M: Amit Shah <amit.shah@redhat.com>
 S: Supported
-- 
1.6.0.2

[Qemu-devel] [PATCH 3/5] Allow virtio-net features for legacy s390 virtio bus

[Alexander Graf]

From: Christian Borntraeger <borntraeger@de.ibm.com>

Enable all virtio-net features for the legacy s390 virtio bus. This also fixes
kernel BUG at /usr/src/packages/BUILD/kernel-default-3.0.58/linux-3.0/drivers/s390/kvm/kvm_virtio.c:121!

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Alexander Graf <agraf@suse.de>
---
 hw/s390x/s390-virtio-bus.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c
index 089ed92..d9b7f83 100644
--- a/hw/s390x/s390-virtio-bus.c
+++ b/hw/s390x/s390-virtio-bus.c
@@ -402,6 +402,7 @@ static const VirtIOBindings virtio_s390_bindings = {
 
 static Property s390_virtio_net_properties[] = {
     DEFINE_NIC_PROPERTIES(VirtIOS390Device, nic),
+    DEFINE_VIRTIO_NET_FEATURES(VirtIOS390Device, host_features),
     DEFINE_PROP_UINT32("x-txtimer", VirtIOS390Device,
                        net.txtimer, TX_TIMER_INTERVAL),
     DEFINE_PROP_INT32("x-txburst", VirtIOS390Device,
-- 
1.6.0.2

[Qemu-devel] [PATCH 4/5] s390/css: Fix subchannel detection

[Alexander Graf]

From: Christian Borntraeger <borntraeger@de.ibm.com>

We have to consider the m bit to find the real channel subsystem when
determining the last subchannel.

If we fail to take this into account, removal of a subchannel in
the middle of a big list of devices will stop device detection after
a reboot.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Jens Freimann <jfrei@linux.vnet.ibm.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
 hw/s390x/css.c        |   11 +++++++----
 target-s390x/cpu.h    |    2 +-
 target-s390x/ioinst.c |    2 +-
 3 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/hw/s390x/css.c b/hw/s390x/css.c
index 85f6f22..e526a1c 100644
--- a/hw/s390x/css.c
+++ b/hw/s390x/css.c
@@ -988,15 +988,18 @@ int css_do_rchp(uint8_t cssid, uint8_t chpid)
     return 0;
 }
 
-bool css_schid_final(uint8_t cssid, uint8_t ssid, uint16_t schid)
+bool css_schid_final(int m, uint8_t cssid, uint8_t ssid, uint16_t schid)
 {
     SubchSet *set;
+    uint8_t real_cssid;
 
-    if (cssid > MAX_CSSID || ssid > MAX_SSID || !channel_subsys->css[cssid] ||
-        !channel_subsys->css[cssid]->sch_set[ssid]) {
+    real_cssid = (!m && (cssid == 0)) ? channel_subsys->default_cssid : cssid;
+    if (real_cssid > MAX_CSSID || ssid > MAX_SSID ||
+        !channel_subsys->css[real_cssid] ||
+        !channel_subsys->css[real_cssid]->sch_set[ssid]) {
         return true;
     }
-    set = channel_subsys->css[cssid]->sch_set[ssid];
+    set = channel_subsys->css[real_cssid]->sch_set[ssid];
     return schid > find_last_bit(set->schids_used,
                                  (MAX_SCHID + 1) / sizeof(unsigned long));
 }
diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h
index e450db7..9cb739d 100644
--- a/target-s390x/cpu.h
+++ b/target-s390x/cpu.h
@@ -404,7 +404,7 @@ SubchDev *css_find_subch(uint8_t m, uint8_t cssid, uint8_t ssid,
 bool css_subch_visible(SubchDev *sch);
 void css_conditional_io_interrupt(SubchDev *sch);
 int css_do_stsch(SubchDev *sch, SCHIB *schib);
-bool css_schid_final(uint8_t cssid, uint8_t ssid, uint16_t schid);
+bool css_schid_final(int m, uint8_t cssid, uint8_t ssid, uint16_t schid);
 int css_do_msch(SubchDev *sch, SCHIB *schib);
 int css_do_xsch(SubchDev *sch);
 int css_do_csch(SubchDev *sch);
diff --git a/target-s390x/ioinst.c b/target-s390x/ioinst.c
index e3531f3..28c508d 100644
--- a/target-s390x/ioinst.c
+++ b/target-s390x/ioinst.c
@@ -316,7 +316,7 @@ int ioinst_handle_stsch(CPUS390XState *env, uint64_t reg1, uint32_t ipb)
             cc = 3;
         }
     } else {
-        if (css_schid_final(cssid, ssid, schid)) {
+        if (css_schid_final(m, cssid, ssid, schid)) {
             cc = 3; /* No more subchannels in this css/ss */
         } else {
             /* Store an empty schib. */
-- 
1.6.0.2

[Qemu-devel] [PATCH 5/5] s390/virtio-ccw: remove redundant call to blockdev_mark_auto_del

[Alexander Graf]

From: Christian Borntraeger <borntraeger@de.ibm.com>

blockdev_mark_auto_del is already called in virtio-blk-exit.
Remove the redundant call.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Jens Freimann <jfrei@linux.vnet.ibm.com>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
 hw/s390x/virtio-ccw.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
index d92e427..a9cf703 100644
--- a/hw/s390x/virtio-ccw.c
+++ b/hw/s390x/virtio-ccw.c
@@ -585,7 +585,6 @@ static int virtio_ccw_blk_init(VirtioCcwDevice *dev)
 static int virtio_ccw_blk_exit(VirtioCcwDevice *dev)
 {
     virtio_blk_exit(dev->vdev);
-    blockdev_mark_auto_del(dev->blk.conf.bs);
     return virtio_ccw_exit(dev);
 }
 
-- 
1.6.0.2

Re: [Qemu-devel] [PULL 0/5] s390 patch queue 2013-03-08

[Blue Swirl]

On Fri, Mar 8, 2013 at 8:17 PM, Alexander Graf <agraf@suse.de> wrote:
> Hi Blue / Aurelien,
>
> This is my current patch queue for s390.  Please pull.

Thanks, pulled.

>
> Alex
>
>
> The following changes since commit 0bc472a9d6b80567c212023c5eae413f4dfb53ad:
>   Kuo-Jung Su (1):
>         hw/nand.c: correct the sense of the BUSY/READY status bit
>
> are available in the git repository at:
>
>   git://github.com/agraf/qemu.git s390-for-upstream
>
> Christian Borntraeger (4):
>       s390: simplify kvm cpu init
>       Allow virtio-net features for legacy s390 virtio bus
>       s390/css: Fix subchannel detection
>       s390/virtio-ccw: remove redundant call to blockdev_mark_auto_del
>
> Cornelia Huck (1):
>       s390: virtio-ccw maintainer
>
>  MAINTAINERS                |   14 ++++++++++++++
>  hw/s390x/css.c             |   11 +++++++----
>  hw/s390x/s390-virtio-bus.c |    1 +
>  hw/s390x/virtio-ccw.c      |    1 -
>  target-s390x/cpu.h         |    2 +-
>  target-s390x/ioinst.c      |    2 +-
>  target-s390x/kvm.c         |    9 ++-------
>  7 files changed, 26 insertions(+), 14 deletions(-)