From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEgbm-0003eQ-RD for qemu-devel@nongnu.org; Sun, 10 Mar 2013 09:48:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UEgbj-0001Up-NB for qemu-devel@nongnu.org; Sun, 10 Mar 2013 09:48:14 -0400 Received: from mail-la0-x22e.google.com ([2a00:1450:4010:c03::22e]:41197) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEgbj-0001Ue-FH for qemu-devel@nongnu.org; Sun, 10 Mar 2013 09:48:11 -0400 Received: by mail-la0-f46.google.com with SMTP id fq12so3075105lab.33 for ; Sun, 10 Mar 2013 06:48:10 -0700 (PDT) From: Igor Mitsyanko Date: Sun, 10 Mar 2013 17:47:58 +0400 Message-Id: <1362923278-4080-4-git-send-email-i.mitsyanko@gmail.com> In-Reply-To: <1362923278-4080-1-git-send-email-i.mitsyanko@gmail.com> References: <1362923278-4080-1-git-send-email-i.mitsyanko@gmail.com> Subject: [Qemu-devel] [PATCH 3/3] hw/onenand.c: fix migration of dynamically allocated buffer "otp" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, i.mitsyanko@gmail.com, andrew@openedhand.com, michael@walle.cc, paul@codesourcery.com, anthony@codemonkey.ws VMSTATE_BUFFER_UNSAFE should be used for buffers inlined in device state, not for buffers allocated dynamically. Change to VMSTATE_BUFFER_POINTER_UNSAFE macro, which will do migration right. Signed-off-by: Igor Mitsyanko --- hw/onenand.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/onenand.c b/hw/onenand.c index 00a8738..12ccb67f 100644 --- a/hw/onenand.c +++ b/hw/onenand.c @@ -185,7 +185,8 @@ static const VMStateDescription vmstate_onenand = { VMSTATE_UINT8(ecc.cp, OneNANDState), VMSTATE_UINT16_ARRAY(ecc.lp, OneNANDState, 2), VMSTATE_UINT16(ecc.count, OneNANDState), - VMSTATE_BUFFER_UNSAFE(otp, OneNANDState, 0, ((64 + 2) << PAGE_SHIFT)), + VMSTATE_BUFFER_POINTER_UNSAFE(otp, OneNANDState, 0, + ((64 + 2) << PAGE_SHIFT)), VMSTATE_END_OF_LIST() } }; -- 1.7.5.4