* [Qemu-devel] [PATCH] qemu-char.c: fix waiting for telnet connection message
@ 2013-03-10 13:58 Igor Mitsyanko
2013-03-11 9:28 ` Markus Armbruster
0 siblings, 1 reply; 2+ messages in thread
From: Igor Mitsyanko @ 2013-03-10 13:58 UTC (permalink / raw)
To: qemu-trivial; +Cc: i.mitsyanko, qemu-devel
Current colon position in "waiting for telnet connection" message template
produces messages like:
QEMU waiting for connection on: telnet::127.0.0.16666,server
After moving a colon to the right, we will get a correct messages like:
QEMU waiting for connection on: telnet:127.0.0.1:6666,server
Signed-off-by: Igor Mitsyanko <i.mitsyanko@gmail.com>
---
qemu-char.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 36295b1..789ee35 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2476,7 +2476,7 @@ static CharDriverState *qemu_chr_open_socket_fd(int fd, bool do_nodelay,
s->do_nodelay = do_nodelay;
getnameinfo((struct sockaddr *) &ss, ss_len, host, sizeof(host),
serv, sizeof(serv), NI_NUMERICHOST | NI_NUMERICSERV);
- snprintf(chr->filename, 256, "%s:%s:%s%s%s%s",
+ snprintf(chr->filename, 256, "%s:%s%s%s:%s%s",
is_telnet ? "telnet" : "tcp",
left, host, right, serv,
is_listen ? ",server" : "");
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-char.c: fix waiting for telnet connection message
2013-03-10 13:58 [Qemu-devel] [PATCH] qemu-char.c: fix waiting for telnet connection message Igor Mitsyanko
@ 2013-03-11 9:28 ` Markus Armbruster
0 siblings, 0 replies; 2+ messages in thread
From: Markus Armbruster @ 2013-03-11 9:28 UTC (permalink / raw)
To: Igor Mitsyanko; +Cc: qemu-trivial, qemu-devel, Gerd Hoffmann
Igor Mitsyanko <i.mitsyanko@gmail.com> writes:
> Current colon position in "waiting for telnet connection" message template
> produces messages like:
> QEMU waiting for connection on: telnet::127.0.0.16666,server
>
> After moving a colon to the right, we will get a correct messages like:
> QEMU waiting for connection on: telnet:127.0.0.1:6666,server
>
> Signed-off-by: Igor Mitsyanko <i.mitsyanko@gmail.com>
> ---
> qemu-char.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 36295b1..789ee35 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -2476,7 +2476,7 @@ static CharDriverState *qemu_chr_open_socket_fd(int fd, bool do_nodelay,
> s->do_nodelay = do_nodelay;
> getnameinfo((struct sockaddr *) &ss, ss_len, host, sizeof(host),
> serv, sizeof(serv), NI_NUMERICHOST | NI_NUMERICSERV);
> - snprintf(chr->filename, 256, "%s:%s:%s%s%s%s",
> + snprintf(chr->filename, 256, "%s:%s%s%s:%s%s",
> is_telnet ? "telnet" : "tcp",
> left, host, right, serv,
> is_listen ? ",server" : "");
Broken in commit f6bd5d6e. Nice to have that information in the commit
message, but not worth a respin.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-11 9:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-10 13:58 [Qemu-devel] [PATCH] qemu-char.c: fix waiting for telnet connection message Igor Mitsyanko
2013-03-11 9:28 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).