From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38688) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEh8U-0002Os-1M for qemu-devel@nongnu.org; Sun, 10 Mar 2013 10:22:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UEh8O-0003BX-TH for qemu-devel@nongnu.org; Sun, 10 Mar 2013 10:22:01 -0400 Received: from mail-la0-x22b.google.com ([2a00:1450:4010:c03::22b]:41274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEh8O-0003BP-Lj for qemu-devel@nongnu.org; Sun, 10 Mar 2013 10:21:56 -0400 Received: by mail-la0-f43.google.com with SMTP id ek20so3097827lab.30 for ; Sun, 10 Mar 2013 07:21:55 -0700 (PDT) From: Igor Mitsyanko Date: Sun, 10 Mar 2013 18:21:47 +0400 Message-Id: <1362925309-3852-2-git-send-email-i.mitsyanko@gmail.com> In-Reply-To: <1362925309-3852-1-git-send-email-i.mitsyanko@gmail.com> References: <1362925309-3852-1-git-send-email-i.mitsyanko@gmail.com> Subject: [Qemu-devel] [PATCH 1/3] hw/exynos4210.c: set chipid_and_omr array size to TARGET_PAGE_SIZE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: i.mitsyanko@gmail.com, peter.maydell@linaro.org, afaerber@suse.de, anthony@codemonkey.ws, pbonzini@redhat.com During initialization, memory region size is aligned to page size, but size of chipid_and_omr array is less then TARGET_PAGE_SIZE. This could result in errors in some cases, specifically, it could cause errors during VM migration. Signed-off-by: Igor Mitsyanko --- hw/exynos4210.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/exynos4210.c b/hw/exynos4210.c index fa54e42..280d5d4 100644 --- a/hw/exynos4210.c +++ b/hw/exynos4210.c @@ -76,7 +76,7 @@ /* EHCI */ #define EXYNOS4210_EHCI_BASE_ADDR 0x12580000 -static uint8_t chipid_and_omr[] = { 0x11, 0x02, 0x21, 0x43, +static uint8_t chipid_and_omr[TARGET_PAGE_SIZE] = { 0x11, 0x02, 0x21, 0x43, 0x09, 0x00, 0x00, 0x00 }; void exynos4210_write_secondary(ARMCPU *cpu, -- 1.7.5.4