From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEh8X-0002P8-Iz for qemu-devel@nongnu.org; Sun, 10 Mar 2013 10:22:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UEh8R-0003CV-PL for qemu-devel@nongnu.org; Sun, 10 Mar 2013 10:22:05 -0400 Received: from mail-lb0-f170.google.com ([209.85.217.170]:65457) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEh8R-0003CA-Gl for qemu-devel@nongnu.org; Sun, 10 Mar 2013 10:21:59 -0400 Received: by mail-lb0-f170.google.com with SMTP id ge1so2493347lbb.29 for ; Sun, 10 Mar 2013 07:21:58 -0700 (PDT) From: Igor Mitsyanko Date: Sun, 10 Mar 2013 18:21:48 +0400 Message-Id: <1362925309-3852-3-git-send-email-i.mitsyanko@gmail.com> In-Reply-To: <1362925309-3852-1-git-send-email-i.mitsyanko@gmail.com> References: <1362925309-3852-1-git-send-email-i.mitsyanko@gmail.com> Subject: [Qemu-devel] [PATCH 2/3] exynos4210.c: register chipid_mem and rom_mem with vmstate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: i.mitsyanko@gmail.com, peter.maydell@linaro.org, afaerber@suse.de, anthony@codemonkey.ws, pbonzini@redhat.com Even if we do not register newly created RAM MemoryRegion for migration with vmstate_register_ram_global() function, ram_save_setup() still saves this region to snapshot file with empty idstr=="". Consequently this results in error during VM loading in ram_load(). Register chipid_mem and rom_mem for migration. Signed-off-by: Igor Mitsyanko --- hw/exynos4210.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/exynos4210.c b/hw/exynos4210.c index 280d5d4..af741e2 100644 --- a/hw/exynos4210.c +++ b/hw/exynos4210.c @@ -221,6 +221,7 @@ Exynos4210State *exynos4210_init(MemoryRegion *system_mem, /* Chip-ID and OMR */ memory_region_init_ram_ptr(&s->chipid_mem, "exynos4210.chipid", sizeof(chipid_and_omr), chipid_and_omr); + vmstate_register_ram_global(&s->chipid_mem); memory_region_set_readonly(&s->chipid_mem, true); memory_region_add_subregion(system_mem, EXYNOS4210_CHIPID_ADDR, &s->chipid_mem); @@ -228,6 +229,7 @@ Exynos4210State *exynos4210_init(MemoryRegion *system_mem, /* Internal ROM */ memory_region_init_ram(&s->irom_mem, "exynos4210.irom", EXYNOS4210_IROM_SIZE); + vmstate_register_ram_global(&s->irom_mem); memory_region_set_readonly(&s->irom_mem, true); memory_region_add_subregion(system_mem, EXYNOS4210_IROM_BASE_ADDR, &s->irom_mem); -- 1.7.5.4