From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH 0/2] pci: handle zero size ROM files gracefully
Date: Mon, 11 Mar 2013 10:20:19 +0100 [thread overview]
Message-ID: <1362993621-30993-1-git-send-email-stefanha@redhat.com> (raw)
This is a fix for https://bugs.launchpad.net/qemu/+bug/1127053.
If pxe-e1000.rom has 0 size we allocate the same RAMBlock offset twice and fail
with an assertion in qemu_ram_set_idstr() later on.
Two fixes:
1. Print an error when the ROM file has zero size. Use -device ...,romfile=
instead to disable the ROM.
2. Add an assertion to find_ram_offset() so we watch this inconsistency if it
ever happens again.
Stefan Hajnoczi (2):
pci: refuse empty ROM files
exec: assert that RAMBlock size is non-zero
exec.c | 2 ++
hw/pci/pci.c | 7 ++++++-
2 files changed, 8 insertions(+), 1 deletion(-)
--
1.8.1.4
next reply other threads:[~2013-03-11 9:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 9:20 Stefan Hajnoczi [this message]
2013-03-11 9:20 ` [Qemu-devel] [PATCH 1/2] pci: refuse empty ROM files Stefan Hajnoczi
2013-03-11 9:20 ` [Qemu-devel] [PATCH 2/2] exec: assert that RAMBlock size is non-zero Stefan Hajnoczi
2013-03-11 9:23 ` [Qemu-devel] [PATCH 0/2] pci: handle zero size ROM files gracefully Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362993621-30993-1-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).