qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, lersek@redhat.com, lilei@linux.vnet.ibm.com,
	stefanha@redhat.com
Subject: [Qemu-devel] [PATCH 2/9] qemu-ga: fix confusing GAChannelMethod comparison
Date: Mon, 11 Mar 2013 19:53:13 -0500	[thread overview]
Message-ID: <1363049600-29456-3-git-send-email-mdroth@linux.vnet.ibm.com> (raw)
In-Reply-To: <1363049600-29456-1-git-send-email-mdroth@linux.vnet.ibm.com>

From: Stefan Hajnoczi <stefanha@redhat.com>

In commit 7868e26e5930f49ca942311885776b938dcf3b77
("qemu-ga: add initial win32 support") support was added for qemu-ga on
Windows using virtio-serial.  Other channel methods (ISA serial and UNIX
domain socket) are not supported on Windows.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
 qga/channel-win32.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qga/channel-win32.c b/qga/channel-win32.c
index 16bf44a..7ed98d7 100644
--- a/qga/channel-win32.c
+++ b/qga/channel-win32.c
@@ -287,7 +287,7 @@ GIOStatus ga_channel_write_all(GAChannel *c, const char *buf, size_t size)
 static gboolean ga_channel_open(GAChannel *c, GAChannelMethod method,
                                 const gchar *path)
 {
-    if (!method == GA_CHANNEL_VIRTIO_SERIAL) {
+    if (method != GA_CHANNEL_VIRTIO_SERIAL) {
         g_critical("unsupported communication method");
         return false;
     }
-- 
1.7.9.5

  parent reply	other threads:[~2013-03-12  0:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-12  0:53 [Qemu-devel] [PULL 0/9] qemu-ga fixes and {get, set}-{time, vcpus} commands Michael Roth
2013-03-12  0:53 ` [Qemu-devel] [PATCH 1/9] qga: cast to int for DWORD type Michael Roth
2013-03-12  0:53 ` Michael Roth [this message]
2013-03-12  0:53 ` [Qemu-devel] [PATCH 3/9] qemu-ga: make guest-sync-delimited available during fsfreeze Michael Roth
2013-03-12  0:53 ` [Qemu-devel] [PATCH 4/9] qemu-ga: use key-value store to avoid recycling fd handles after restart Michael Roth
2013-03-15  3:31   ` Peter Crosthwaite
2013-03-15  3:52     ` Michael Roth
2013-03-15  5:09       ` Peter Crosthwaite
2013-03-12  0:53 ` [Qemu-devel] [PATCH 5/9] qga: add guest-get-time command Michael Roth
2013-03-12  0:53 ` [Qemu-devel] [PATCH 6/9] qga: add guest-set-time command Michael Roth
2013-03-12  0:53 ` [Qemu-devel] [PATCH 7/9] qga: introduce guest-get-vcpus / guest-set-vcpus with stubs Michael Roth
2013-03-12  0:53 ` [Qemu-devel] [PATCH 8/9] qga: implement qmp_guest_get_vcpus() for Linux with sysfs Michael Roth
2013-03-12  0:53 ` [Qemu-devel] [PATCH 9/9] qga: implement qmp_guest_set_vcpus() " Michael Roth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363049600-29456-3-git-send-email-mdroth@linux.vnet.ibm.com \
    --to=mdroth@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=lersek@redhat.com \
    --cc=lilei@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).