From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFDUx-0005Kx-2L for qemu-devel@nongnu.org; Mon, 11 Mar 2013 20:55:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFDUv-0000ZT-0j for qemu-devel@nongnu.org; Mon, 11 Mar 2013 20:55:22 -0400 Received: from mail-oa0-f54.google.com ([209.85.219.54]:54456) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFDUu-0000ZP-S0 for qemu-devel@nongnu.org; Mon, 11 Mar 2013 20:55:20 -0400 Received: by mail-oa0-f54.google.com with SMTP id n12so5164089oag.27 for ; Mon, 11 Mar 2013 17:55:20 -0700 (PDT) Sender: fluxion From: Michael Roth Date: Mon, 11 Mar 2013 19:53:13 -0500 Message-Id: <1363049600-29456-3-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1363049600-29456-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1363049600-29456-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 2/9] qemu-ga: fix confusing GAChannelMethod comparison List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, lersek@redhat.com, lilei@linux.vnet.ibm.com, stefanha@redhat.com From: Stefan Hajnoczi In commit 7868e26e5930f49ca942311885776b938dcf3b77 ("qemu-ga: add initial win32 support") support was added for qemu-ga on Windows using virtio-serial. Other channel methods (ISA serial and UNIX domain socket) are not supported on Windows. Signed-off-by: Stefan Hajnoczi Signed-off-by: Michael Roth --- qga/channel-win32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/channel-win32.c b/qga/channel-win32.c index 16bf44a..7ed98d7 100644 --- a/qga/channel-win32.c +++ b/qga/channel-win32.c @@ -287,7 +287,7 @@ GIOStatus ga_channel_write_all(GAChannel *c, const char *buf, size_t size) static gboolean ga_channel_open(GAChannel *c, GAChannelMethod method, const gchar *path) { - if (!method == GA_CHANNEL_VIRTIO_SERIAL) { + if (method != GA_CHANNEL_VIRTIO_SERIAL) { g_critical("unsupported communication method"); return false; } -- 1.7.9.5