From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Igor Mitsyanko <i.mitsyanko@gmail.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 19/19] qemu-char.c: fix waiting for telnet connection message
Date: Tue, 12 Mar 2013 09:56:29 +0100 [thread overview]
Message-ID: <1363078589-15233-20-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1363078589-15233-1-git-send-email-kraxel@redhat.com>
From: Igor Mitsyanko <i.mitsyanko@gmail.com>
Current colon position in "waiting for telnet connection" message template
produces messages like:
QEMU waiting for connection on: telnet::127.0.0.16666,server
After moving a colon to the right, we will get a correct messages like:
QEMU waiting for connection on: telnet:127.0.0.1:6666,server
Signed-off-by: Igor Mitsyanko <i.mitsyanko@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
qemu-char.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-char.c b/qemu-char.c
index 11f8ea5..a9f0520 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2632,7 +2632,7 @@ static CharDriverState *qemu_chr_open_socket_fd(int fd, bool do_nodelay,
s->do_nodelay = do_nodelay;
getnameinfo((struct sockaddr *) &ss, ss_len, host, sizeof(host),
serv, sizeof(serv), NI_NUMERICHOST | NI_NUMERICSERV);
- snprintf(chr->filename, 256, "%s:%s:%s%s%s%s",
+ snprintf(chr->filename, 256, "%s:%s%s%s:%s%s",
is_telnet ? "telnet" : "tcp",
left, host, right, serv,
is_listen ? ",server" : "");
--
1.7.9.7
next prev parent reply other threads:[~2013-03-12 9:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 8:56 [Qemu-devel] [PULL v3 00/19] chardev: qapi conversion continued Gerd Hoffmann
2013-03-12 8:56 ` [Qemu-devel] [PATCH 01/19] chardev: add support for qapi-based chardev initialization Gerd Hoffmann
2013-03-12 8:56 ` [Qemu-devel] [PATCH 02/19] chardev: add mux chardev support to qapi Gerd Hoffmann
2013-03-12 8:56 ` [Qemu-devel] [PATCH 03/19] chardev: switch null init " Gerd Hoffmann
2013-03-12 8:56 ` [Qemu-devel] [PATCH 04/19] chardev: add msmouse support " Gerd Hoffmann
2013-03-12 8:56 ` [Qemu-devel] [PATCH 05/19] chardev: add braille " Gerd Hoffmann
2013-03-12 8:56 ` [Qemu-devel] [PATCH 06/19] chardev: switch file init " Gerd Hoffmann
2013-03-12 8:56 ` [Qemu-devel] [PATCH 07/19] chardev: add stdio support " Gerd Hoffmann
2013-03-12 8:56 ` [Qemu-devel] [PATCH 08/19] chardev: switch serial/tty init " Gerd Hoffmann
2013-03-12 8:56 ` [Qemu-devel] [PATCH 09/19] chardev: switch parallel " Gerd Hoffmann
2013-03-12 8:56 ` [Qemu-devel] [PATCH 10/19] chardev: switch pty " Gerd Hoffmann
2013-03-12 8:56 ` [Qemu-devel] [PATCH 11/19] chardev: add console support " Gerd Hoffmann
2013-03-12 8:56 ` [Qemu-devel] [PATCH 12/19] chardev: add pipe " Gerd Hoffmann
2013-03-12 8:56 ` [Qemu-devel] [PATCH 13/19] chardev: add spice " Gerd Hoffmann
2013-03-12 8:56 ` [Qemu-devel] [PATCH 14/19] chardev: add vc " Gerd Hoffmann
2013-03-12 8:56 ` [Qemu-devel] [PATCH 15/19] [fixup] vc Gerd Hoffmann
2013-03-12 17:42 ` Eric Blake
2013-03-13 6:46 ` Gerd Hoffmann
2013-03-12 8:56 ` [Qemu-devel] [PATCH 16/19] chardev: add memory (ringbuf) support to qapi Gerd Hoffmann
2013-03-12 8:56 ` [Qemu-devel] [PATCH 17/19] chardev: add udp " Gerd Hoffmann
2013-03-12 8:56 ` [Qemu-devel] [PATCH 18/19] Revert "hmp: Disable chardev-add and chardev-remove" Gerd Hoffmann
2013-03-12 8:56 ` Gerd Hoffmann [this message]
2013-03-12 9:08 ` [Qemu-devel] [PULL v3 00/19] chardev: qapi conversion continued Gerd Hoffmann
2013-03-13 12:39 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363078589-15233-20-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=i.mitsyanko@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).