From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFL0f-0005pX-72 for qemu-devel@nongnu.org; Tue, 12 Mar 2013 04:56:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFL0b-0003zG-OA for qemu-devel@nongnu.org; Tue, 12 Mar 2013 04:56:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53263) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFL0b-0003yY-Ey for qemu-devel@nongnu.org; Tue, 12 Mar 2013 04:56:33 -0400 From: Gerd Hoffmann Date: Tue, 12 Mar 2013 09:56:18 +0100 Message-Id: <1363078589-15233-9-git-send-email-kraxel@redhat.com> In-Reply-To: <1363078589-15233-1-git-send-email-kraxel@redhat.com> References: <1363078589-15233-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH 08/19] chardev: switch serial/tty init to qapi List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , Gerd Hoffmann This patch switches over the serial chardev initialization to the new qapi code path. Signed-off-by: Gerd Hoffmann --- qemu-char.c | 37 +++++++++++++++++-------------------- 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 10f5f57..8bedabb 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -1395,18 +1395,6 @@ static CharDriverState *qemu_chr_open_tty_fd(int fd) chr->chr_close = qemu_chr_close_tty; return chr; } - -static CharDriverState *qemu_chr_open_tty(QemuOpts *opts) -{ - const char *filename = qemu_opt_get(opts, "path"); - int fd; - - TFR(fd = qemu_open(filename, O_RDWR | O_NONBLOCK)); - if (fd < 0) { - return NULL; - } - return qemu_chr_open_tty_fd(fd); -} #endif /* __linux__ || __sun__ */ #if defined(__linux__) @@ -1831,11 +1819,6 @@ static CharDriverState *qemu_chr_open_win_path(const char *filename) return chr; } -static CharDriverState *qemu_chr_open_win(QemuOpts *opts) -{ - return qemu_chr_open_win_path(qemu_opt_get(opts, "path")); -} - static int win_chr_pipe_poll(void *opaque) { CharDriverState *chr = opaque; @@ -3176,6 +3159,19 @@ static void qemu_chr_parse_stdio(QemuOpts *opts, ChardevBackend *backend, qemu_opt_get_bool(opts, "signal", display_type != DT_NOGRAPHIC); } +static void qemu_chr_parse_serial(QemuOpts *opts, ChardevBackend *backend, + Error **errp) +{ + const char *device = qemu_opt_get(opts, "path"); + + if (device == NULL) { + error_setg(errp, "chardev: serial/tty: no device path given"); + return; + } + backend->serial = g_new0(ChardevHostdev, 1); + backend->serial->device = g_strdup(device); +} + typedef struct CharDriver { const char *name; /* old, pre qapi */ @@ -3751,16 +3747,17 @@ static void register_types(void) qemu_chr_parse_file_out); register_char_driver_qapi("stdio", CHARDEV_BACKEND_KIND_STDIO, qemu_chr_parse_stdio); + register_char_driver_qapi("serial", CHARDEV_BACKEND_KIND_SERIAL, + qemu_chr_parse_serial); + register_char_driver_qapi("tty", CHARDEV_BACKEND_KIND_SERIAL, + qemu_chr_parse_serial); #ifdef _WIN32 register_char_driver("pipe", qemu_chr_open_win_pipe); register_char_driver("console", qemu_chr_open_win_con); - register_char_driver("serial", qemu_chr_open_win); #else register_char_driver("pipe", qemu_chr_open_pipe); #endif #ifdef HAVE_CHARDEV_TTY - register_char_driver("tty", qemu_chr_open_tty); - register_char_driver("serial", qemu_chr_open_tty); register_char_driver("pty", qemu_chr_open_pty); #endif #ifdef HAVE_CHARDEV_PARPORT -- 1.7.9.7