From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFLpt-0001D1-Up for qemu-devel@nongnu.org; Tue, 12 Mar 2013 05:49:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFLpk-0008Gt-K8 for qemu-devel@nongnu.org; Tue, 12 Mar 2013 05:49:33 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60983 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFLpk-0008Gf-Dp for qemu-devel@nongnu.org; Tue, 12 Mar 2013 05:49:24 -0400 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Tue, 12 Mar 2013 10:49:03 +0100 Message-Id: <1363081758-12913-3-git-send-email-afaerber@suse.de> In-Reply-To: <1363081758-12913-1-git-send-email-afaerber@suse.de> References: <1363081758-12913-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH 02/17] monitor: Use qemu_get_cpu() in monitor_set_cpu() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Markus Armbruster , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Luiz Capitulino No functional change, just a reduction of CPU loops. The mon_cpu field is left untouched for now since changing that requires a number of larger prerequisites, including cpu_synchronize_state() and mon_get_cpu(). Reviewed-by: Luiz Capitulino Reviewed-by: Markus Armbruster Signed-off-by: Andreas F=C3=A4rber --- monitor.c | 13 +++++-------- 1 Datei ge=C3=A4ndert, 5 Zeilen hinzugef=C3=BCgt(+), 8 Zeilen entfernt(-= ) diff --git a/monitor.c b/monitor.c index c48530b..ab05c49 100644 --- a/monitor.c +++ b/monitor.c @@ -855,17 +855,14 @@ EventInfoList *qmp_query_events(Error **errp) /* set the current CPU defined by the user */ int monitor_set_cpu(int cpu_index) { - CPUArchState *env; CPUState *cpu; =20 - for (env =3D first_cpu; env !=3D NULL; env =3D env->next_cpu) { - cpu =3D ENV_GET_CPU(env); - if (cpu->cpu_index =3D=3D cpu_index) { - cur_mon->mon_cpu =3D env; - return 0; - } + cpu =3D qemu_get_cpu(cpu_index); + if (cpu =3D=3D NULL) { + return -1; } - return -1; + cur_mon->mon_cpu =3D cpu->env_ptr; + return 0; } =20 static CPUArchState *mon_get_cpu(void) --=20 1.7.10.4