From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60085) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFLpo-00017P-S9 for qemu-devel@nongnu.org; Tue, 12 Mar 2013 05:49:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFLpk-0008Gz-Oq for qemu-devel@nongnu.org; Tue, 12 Mar 2013 05:49:28 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60984 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFLpk-0008Gh-IX for qemu-devel@nongnu.org; Tue, 12 Mar 2013 05:49:24 -0400 Received: from relay1.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 109D8A4E0C for ; Tue, 12 Mar 2013 10:49:24 +0100 (CET) From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Tue, 12 Mar 2013 10:49:04 +0100 Message-Id: <1363081758-12913-4-git-send-email-afaerber@suse.de> In-Reply-To: <1363081758-12913-1-git-send-email-afaerber@suse.de> References: <1363081758-12913-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH 03/17] cpus: Replace open-coded CPU loop in qmp_memsave() with qemu_get_cpu() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Andreas=20F=C3=A4rber?= No functional change, just less usages of first_cpu and next_cpu fields. env is passed to cpu_memory_rw_debug(), which in turn passes it to target-specific cpu_get_phys_page_debug(). Changing both would be a larger refactoring, so defer that by using env_ptr for now. Reviewed-by: Luiz Capitulino Signed-off-by: Andreas F=C3=A4rber --- cpus.c | 11 +++-------- 1 Datei ge=C3=A4ndert, 3 Zeilen hinzugef=C3=BCgt(+), 8 Zeilen entfernt(-= ) diff --git a/cpus.c b/cpus.c index c4b021d..46355c1 100644 --- a/cpus.c +++ b/cpus.c @@ -1241,18 +1241,13 @@ void qmp_memsave(int64_t addr, int64_t size, cons= t char *filename, cpu_index =3D 0; } =20 - for (env =3D first_cpu; env; env =3D env->next_cpu) { - cpu =3D ENV_GET_CPU(env); - if (cpu_index =3D=3D cpu->cpu_index) { - break; - } - } - - if (env =3D=3D NULL) { + cpu =3D qemu_get_cpu(cpu_index); + if (cpu =3D=3D NULL) { error_set(errp, QERR_INVALID_PARAMETER_VALUE, "cpu-index", "a CPU number"); return; } + env =3D cpu->env_ptr; =20 f =3D fopen(filename, "wb"); if (!f) { --=20 1.7.10.4