From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFQOb-0001C3-5Y for qemu-devel@nongnu.org; Tue, 12 Mar 2013 10:41:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFQOZ-0002Pv-Cw for qemu-devel@nongnu.org; Tue, 12 Mar 2013 10:41:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33766) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFQOZ-0002Pa-62 for qemu-devel@nongnu.org; Tue, 12 Mar 2013 10:41:39 -0400 From: Kevin Wolf Date: Tue, 12 Mar 2013 15:41:19 +0100 Message-Id: <1363099279-403-14-git-send-email-kwolf@redhat.com> In-Reply-To: <1363099279-403-1-git-send-email-kwolf@redhat.com> References: <1363099279-403-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 13/13] qcow2: drop unnecessary flush in qcow2_update_snapshot_refcount() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Stefan Hajnoczi We already flush when the function completes. There is no need to flush after every compressed cluster. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 92519ea..9bfb390 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount.c @@ -790,10 +790,6 @@ int qcow2_update_snapshot_refcount(BlockDriverState *bs, if (ret < 0) { goto fail; } - - /* TODO Flushing once for the whole function should - * be enough */ - bdrv_flush(bs->file); } /* compressed clusters are never modified */ refcount = 2; -- 1.8.1.4