From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFQOZ-00018o-Bo for qemu-devel@nongnu.org; Tue, 12 Mar 2013 10:41:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFQOT-0002Ns-Vn for qemu-devel@nongnu.org; Tue, 12 Mar 2013 10:41:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27017) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFQOT-0002Ne-IF for qemu-devel@nongnu.org; Tue, 12 Mar 2013 10:41:33 -0400 From: Kevin Wolf Date: Tue, 12 Mar 2013 15:41:14 +0100 Message-Id: <1363099279-403-9-git-send-email-kwolf@redhat.com> In-Reply-To: <1363099279-403-1-git-send-email-kwolf@redhat.com> References: <1363099279-403-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 08/13] qcow2: flush refcount cache correctly in alloc_refcount_block() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Stefan Hajnoczi update_refcount() affects the refcount cache, it does not write to disk. Therefore bdrv_flush(bs->file) does nothing. We need to flush the refcount cache in order to write out the refcount updates! While we're here also add error returns when qcow2_cache_flush() fails. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 55543ed..e8b5d0a 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount.c @@ -201,7 +201,10 @@ static int alloc_refcount_block(BlockDriverState *bs, *refcount_block = NULL; /* We write to the refcount table, so we might depend on L2 tables */ - qcow2_cache_flush(bs, s->l2_table_cache); + ret = qcow2_cache_flush(bs, s->l2_table_cache); + if (ret < 0) { + return ret; + } /* Allocate the refcount block itself and mark it as used */ int64_t new_block = alloc_clusters_noref(bs, s->cluster_size); @@ -237,7 +240,10 @@ static int alloc_refcount_block(BlockDriverState *bs, goto fail_block; } - bdrv_flush(bs->file); + ret = qcow2_cache_flush(bs, s->refcount_block_cache); + if (ret < 0) { + goto fail_block; + } /* Initialize the new refcount block only after updating its refcount, * update_refcount uses the refcount cache itself */ -- 1.8.1.4