From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56738) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFo4l-0002Ng-BC for qemu-devel@nongnu.org; Wed, 13 Mar 2013 11:58:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFo4f-0007dg-Tg for qemu-devel@nongnu.org; Wed, 13 Mar 2013 11:58:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFo4f-0007dN-FH for qemu-devel@nongnu.org; Wed, 13 Mar 2013 11:58:41 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2DFwceo006356 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 13 Mar 2013 11:58:39 -0400 From: Alon Levy Date: Wed, 13 Mar 2013 17:58:35 +0200 Message-Id: <1363190315-23956-1-git-send-email-alevy@redhat.com> Subject: [Qemu-devel] [PATCH] spice: (32 bit only) fix surface cmd tracking destruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kraxel@redhat.com No change for 64 bit arches, but for 32 bit previously we zeroed half the surfaces cmd array, instead of all of it. Signed-off-by: Alon Levy --- hw/qxl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index ef69348..4cbab45 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -226,7 +226,7 @@ static void qxl_spice_destroy_surfaces_complete(PCIQXLDevice *qxl) trace_qxl_spice_destroy_surfaces_complete(qxl->id); qemu_mutex_lock(&qxl->track_lock); memset(qxl->guest_surfaces.cmds, 0, - sizeof(qxl->guest_surfaces.cmds) * qxl->ssd.num_surfaces); + sizeof(qxl->guest_surfaces.cmds[0]) * qxl->ssd.num_surfaces); qxl->guest_surfaces.count = 0; qemu_mutex_unlock(&qxl->track_lock); } -- 1.8.1.4