qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 04/20] chardev: add msmouse support to qapi
Date: Thu, 14 Mar 2013 09:57:25 +0100	[thread overview]
Message-ID: <1363251462-31498-5-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1363251462-31498-1-git-send-email-kraxel@redhat.com>

This patch adds 'msmouse' support to qapi and also switches over
the msmouse chardev initialization to the new qapi code path.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 backends/msmouse.c  |    4 ++--
 include/char/char.h |    3 +++
 qapi-schema.json    |    3 ++-
 qemu-char.c         |    3 +++
 4 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/backends/msmouse.c b/backends/msmouse.c
index 407ec87..61052fe 100644
--- a/backends/msmouse.c
+++ b/backends/msmouse.c
@@ -63,7 +63,7 @@ static void msmouse_chr_close (struct CharDriverState *chr)
     g_free (chr);
 }
 
-static CharDriverState *qemu_chr_open_msmouse(QemuOpts *opts)
+CharDriverState *qemu_chr_open_msmouse(void)
 {
     CharDriverState *chr;
 
@@ -78,7 +78,7 @@ static CharDriverState *qemu_chr_open_msmouse(QemuOpts *opts)
 
 static void register_types(void)
 {
-    register_char_driver("msmouse", qemu_chr_open_msmouse);
+    register_char_driver_qapi("msmouse", CHARDEV_BACKEND_KIND_MSMOUSE, NULL);
 }
 
 type_init(register_types);
diff --git a/include/char/char.h b/include/char/char.h
index afe0024..80e8e30 100644
--- a/include/char/char.h
+++ b/include/char/char.h
@@ -261,4 +261,7 @@ size_t qemu_chr_mem_osize(const CharDriverState *chr);
 
 CharDriverState *qemu_char_get_next_serial(void);
 
+/* msmouse */
+CharDriverState *qemu_chr_open_msmouse(void);
+
 #endif
diff --git a/qapi-schema.json b/qapi-schema.json
index 4ad92b0..86c04dc 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -3210,7 +3210,8 @@
                                        'socket' : 'ChardevSocket',
                                        'pty'    : 'ChardevDummy',
                                        'null'   : 'ChardevDummy',
-                                       'mux'    : 'ChardevMux' } }
+                                       'mux'    : 'ChardevMux',
+                                       'msmouse': 'ChardevDummy' } }
 
 ##
 # @ChardevReturn:
diff --git a/qemu-char.c b/qemu-char.c
index e6f67d8..e860ba3 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -3719,6 +3719,9 @@ ChardevReturn *qmp_chardev_add(const char *id, ChardevBackend *backend,
         }
         chr = qemu_chr_open_mux(base);
         break;
+    case CHARDEV_BACKEND_KIND_MSMOUSE:
+        chr = qemu_chr_open_msmouse();
+        break;
     default:
         error_setg(errp, "unknown chardev backend (%d)", backend->kind);
         break;
-- 
1.7.9.7

  parent reply	other threads:[~2013-03-14  8:57 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-14  8:57 [Qemu-devel] [PULL v4 00/20] chardev: qapi conversion continued Gerd Hoffmann
2013-03-14  8:57 ` [Qemu-devel] [PATCH 01/20] chardev: add support for qapi-based chardev initialization Gerd Hoffmann
2013-03-14  8:57 ` [Qemu-devel] [PATCH 02/20] chardev: add mux chardev support to qapi Gerd Hoffmann
2013-03-14  8:57 ` [Qemu-devel] [PATCH 03/20] chardev: switch null init " Gerd Hoffmann
2013-03-14  8:57 ` Gerd Hoffmann [this message]
2013-03-14  8:57 ` [Qemu-devel] [PATCH 05/20] chardev: add braille support " Gerd Hoffmann
2013-03-14  8:57 ` [Qemu-devel] [PATCH 06/20] chardev: switch file init " Gerd Hoffmann
2013-03-14  8:57 ` [Qemu-devel] [PATCH 07/20] chardev: add stdio support " Gerd Hoffmann
2013-03-14  8:57 ` [Qemu-devel] [PATCH 08/20] chardev: switch serial/tty init " Gerd Hoffmann
2013-03-14  8:57 ` [Qemu-devel] [PATCH 09/20] chardev: switch parallel " Gerd Hoffmann
2013-03-14  8:57 ` [Qemu-devel] [PATCH 10/20] chardev: switch pty " Gerd Hoffmann
2013-03-14  8:57 ` [Qemu-devel] [PATCH 11/20] chardev: add console support " Gerd Hoffmann
2013-03-14  8:57 ` [Qemu-devel] [PATCH 12/20] chardev: add pipe " Gerd Hoffmann
2013-03-14  8:57 ` [Qemu-devel] [PATCH 13/20] chardev: add spice " Gerd Hoffmann
2013-03-14  8:57 ` [Qemu-devel] [PATCH 14/20] chardev: add vc " Gerd Hoffmann
2013-03-14  8:57 ` [Qemu-devel] [PATCH 15/20] chardev: add memory (ringbuf) " Gerd Hoffmann
2013-03-14  8:57 ` [Qemu-devel] [PATCH 16/20] chardev: add udp " Gerd Hoffmann
2013-03-14  8:57 ` [Qemu-devel] [PATCH 17/20] Revert "hmp: Disable chardev-add and chardev-remove" Gerd Hoffmann
2013-03-14  8:57 ` [Qemu-devel] [PATCH 18/20] qemu-char.c: fix waiting for telnet connection message Gerd Hoffmann
2013-03-14  8:57 ` [Qemu-devel] [PATCH 19/20] spice-qemu-char: Fix name parameter issues after qapi-ifying Gerd Hoffmann
2013-03-14  8:57 ` [Qemu-devel] [PATCH 20/20] spice-qemu-char: Remove dead debugging code Gerd Hoffmann
2013-03-14 14:27 ` [Qemu-devel] [PULL v4 00/20] chardev: qapi conversion continued Eric Blake
2013-03-14 19:49   ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363251462-31498-5-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).