From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGAgL-0005cu-Hk for qemu-devel@nongnu.org; Thu, 14 Mar 2013 12:07:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UGAgE-0004S6-2K for qemu-devel@nongnu.org; Thu, 14 Mar 2013 12:07:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58901) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGAgD-0004RX-RU for qemu-devel@nongnu.org; Thu, 14 Mar 2013 12:06:58 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2EG6voW010463 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 14 Mar 2013 12:06:57 -0400 From: Stefan Hajnoczi Date: Thu, 14 Mar 2013 17:06:55 +0100 Message-Id: <1363277215-26776-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH] qemu-iotests: use -nographic in test case 007 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf A comment explains that -nographic hangs test case 007. This is no longer the case so add -nographic. This makes the test suite faster and more pleasant to run since no windows pop up. I am not sure exactly when -nographic starting working for this case but there is no fundamental reason why graphics are needed here. Make sure the serial port is not on stdio, it would conflict with the monitor. Also remove unnecessary trailing whitespace on these lines. Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/007 | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/007 b/tests/qemu-iotests/007 index 0139264..c454f2c 100755 --- a/tests/qemu-iotests/007 +++ b/tests/qemu-iotests/007 @@ -50,10 +50,9 @@ _make_test_img 1M for i in `seq 1 10`; do echo "savevm $i" - # XXX(hch): adding -nographic would be good, but hangs the test - $QEMU -hda $TEST_IMG -monitor stdio >/dev/null 2>&1 </dev/null 2>&1 <