From: Hans de Goede <hdegoede@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Amit Shah" <amit.shah@redhat.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Marc-André Lureau" <mlureau@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 1/8] virtio-console: Also throttle when less was written then requested
Date: Thu, 14 Mar 2013 17:36:50 +0100 [thread overview]
Message-ID: <1363279017-3894-2-git-send-email-hdegoede@redhat.com> (raw)
In-Reply-To: <1363279017-3894-1-git-send-email-hdegoede@redhat.com>
This is necessary so that we get properly woken up to write the rest.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Amit Shah <amit.shah@redhat.com>
---
hw/virtio-console.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index e2d1c58..1d87c5b 100644
--- a/hw/virtio-console.c
+++ b/hw/virtio-console.c
@@ -47,7 +47,7 @@ static ssize_t flush_buf(VirtIOSerialPort *port, const uint8_t *buf, size_t len)
ret = qemu_chr_fe_write(vcon->chr, buf, len);
trace_virtio_console_flush_buf(port->id, len, ret);
- if (ret <= 0) {
+ if (ret < len) {
VirtIOSerialPortClass *k = VIRTIO_SERIAL_PORT_GET_CLASS(port);
/*
@@ -56,7 +56,8 @@ static ssize_t flush_buf(VirtIOSerialPort *port, const uint8_t *buf, size_t len)
* we had a finer-grained message, like -EPIPE, we could close
* this connection.
*/
- ret = 0;
+ if (ret < 0)
+ ret = 0;
if (!k->is_console) {
virtio_serial_throttle_port(port, true);
qemu_chr_fe_add_watch(vcon->chr, G_IO_OUT, chr_write_unblocked,
--
1.8.1.4
next prev parent reply other threads:[~2013-03-14 16:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 16:36 [Qemu-devel] Spice / usb-redir chardev flowcontrol patches v2 Hans de Goede
2013-03-14 16:36 ` Hans de Goede [this message]
2013-03-14 16:36 ` [Qemu-devel] [PATCH 2/8] virtio-console: Remove any pending watches on close Hans de Goede
2013-03-18 12:16 ` Amit Shah
2013-03-14 16:36 ` [Qemu-devel] [PATCH 3/8] spice-qemu-char: Remove #ifdef-ed code for old spice-server compat Hans de Goede
2013-03-14 16:36 ` [Qemu-devel] [PATCH 4/8] spice-qemu-char: Add watch support Hans de Goede
2013-03-14 16:36 ` [Qemu-devel] [PATCH 5/8] spice-qemu-char: Remove intermediate buffer Hans de Goede
2013-03-14 16:36 ` [Qemu-devel] [PATCH 6/8] spice-qemu-char: Move spice_chr_close down Hans de Goede
2013-03-14 16:36 ` [Qemu-devel] [PATCH 7/8] spice-qemu-char: Register interface on post load Hans de Goede
2013-03-19 7:05 ` Gerd Hoffmann
2013-03-19 9:15 ` Alon Levy
2013-03-19 9:28 ` Gerd Hoffmann
2013-03-14 16:36 ` [Qemu-devel] [PATCH 8/8] usb-redir: Add flow control support Hans de Goede
2013-03-19 12:40 ` Gerd Hoffmann
2013-03-19 13:54 ` Hans de Goede
2013-03-18 12:21 ` [Qemu-devel] Spice / usb-redir chardev flowcontrol patches v2 Amit Shah
2013-03-19 7:07 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363279017-3894-2-git-send-email-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=amit.shah@redhat.com \
--cc=kraxel@redhat.com \
--cc=mlureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).