From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
To: qemu-devel@nongnu.org
Cc: blauwirbel@gmail.com, aliguori@us.ibm.com,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
mdroth@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH build-breaker] qga/main.c: Don't use g_key_file_get/set_int64
Date: Fri, 15 Mar 2013 15:04:39 +1000 [thread overview]
Message-ID: <1363323879-682-1-git-send-email-peter.crosthwaite@xilinx.com> (raw)
These functions don't exist until glib version 2.26. QEMU is currently only
mandating glib 2.12.
This patch replaces the functions with g_key_file_get/set_integer.
Unbreaks the build on Ubuntu 10.04 and RHEL 5.6.
Regression was introduced by 39097daf15c42243742667607d2cad2c9dc4f764
Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
---
qga/main.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/qga/main.c b/qga/main.c
index 99346e1..74ef788 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -755,7 +755,7 @@ static void persistent_state_from_keyfile(GAPersistentState *pstate,
if (g_key_file_has_key(keyfile, "global", "fd_counter", NULL)) {
pstate->fd_counter =
- g_key_file_get_int64(keyfile, "global", "fd_counter", NULL);
+ g_key_file_get_integer(keyfile, "global", "fd_counter", NULL);
}
}
@@ -765,7 +765,7 @@ static void persistent_state_to_keyfile(const GAPersistentState *pstate,
g_assert(pstate);
g_assert(keyfile);
- g_key_file_set_int64(keyfile, "global", "fd_counter", pstate->fd_counter);
+ g_key_file_set_integer(keyfile, "global", "fd_counter", pstate->fd_counter);
}
static gboolean write_persistent_state(const GAPersistentState *pstate,
--
1.7.0.4
next reply other threads:[~2013-03-15 5:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 5:04 Peter Crosthwaite [this message]
2013-03-15 12:39 ` [Qemu-devel] [PATCH build-breaker] qga/main.c: Don't use g_key_file_get/set_int64 Alexander Graf
2013-03-15 14:12 ` Michael Roth
2013-03-15 17:48 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363323879-682-1-git-send-email-peter.crosthwaite@xilinx.com \
--to=peter.crosthwaite@xilinx.com \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).