qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: fred.konrad@greensocs.com
To: qemu-devel@nongnu.org, aliguori@us.ibm.com
Cc: Kevin Wolf <kwolf@redhat.com>,
	peter.maydell@linaro.org, mst@redhat.com,
	mark.burton@greensocs.com, Stefan Hajnoczi <stefanha@redhat.com>,
	cornelia.huck@de.ibm.com, afaerber@suse.de,
	fred.konrad@greensocs.com
Subject: [Qemu-devel] [PATCH v8 10/10] virtio-blk: cleanup: remove qdev field.
Date: Fri, 15 Mar 2013 10:16:39 +0100	[thread overview]
Message-ID: <1363338999-18210-11-git-send-email-fred.konrad@greensocs.com> (raw)
In-Reply-To: <1363338999-18210-1-git-send-email-fred.konrad@greensocs.com>

From: KONRAD Frederic <fred.konrad@greensocs.com>

The qdev field is no longer needed, just drop it.

Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/virtio-blk.c | 3 +--
 hw/virtio-blk.h | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c
index 663edcd..e6f8875 100644
--- a/hw/virtio-blk.c
+++ b/hw/virtio-blk.c
@@ -669,7 +669,6 @@ static int virtio_blk_device_init(VirtIODevice *vdev)
 #endif
 
     s->change = qemu_add_vm_change_state_handler(virtio_blk_dma_restart_cb, s);
-    s->qdev = qdev;
     register_savevm(qdev, "virtio-blk", virtio_blk_id++, 2,
                     virtio_blk_save, virtio_blk_load, s);
     bdrv_set_dev_ops(s->bs, &virtio_block_ops, s);
@@ -690,7 +689,7 @@ static int virtio_blk_device_exit(DeviceState *dev)
     s->dataplane = NULL;
 #endif
     qemu_del_vm_change_state_handler(s->change);
-    unregister_savevm(s->qdev, "virtio-blk", s);
+    unregister_savevm(dev, "virtio-blk", s);
     blockdev_mark_auto_del(s->bs);
     virtio_common_cleanup(vdev);
     return 0;
diff --git a/hw/virtio-blk.h b/hw/virtio-blk.h
index 51ac010..8c6c78b 100644
--- a/hw/virtio-blk.h
+++ b/hw/virtio-blk.h
@@ -124,7 +124,6 @@ typedef struct VirtIOBlock {
     BlockConf *conf;
     VirtIOBlkConf blk;
     unsigned short sector_mask;
-    DeviceState *qdev;
     VMChangeStateEntry *change;
 #ifdef CONFIG_VIRTIO_BLK_DATA_PLANE
     VirtIOBlockDataPlane *dataplane;
-- 
1.7.11.7

  parent reply	other threads:[~2013-03-15  9:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-15  9:16 [Qemu-devel] [PATCH v8 00/10] virtio-blk refactoring fred.konrad
2013-03-15  9:16 ` [Qemu-devel] [PATCH v8 01/10] virtio: make virtio device's structures public fred.konrad
2013-03-15  9:16 ` [Qemu-devel] [PATCH v8 02/10] virtio-x-bus: fix allow_hotplug assertion fred.konrad
2013-03-15  9:16 ` [Qemu-devel] [PATCH v8 03/10] virtio-blk: don't use pointer for configuration fred.konrad
2013-03-15  9:16 ` [Qemu-devel] [PATCH v8 04/10] virtio-blk: add the virtio-blk device fred.konrad
2013-03-15  9:16 ` [Qemu-devel] [PATCH v8 05/10] virtio-blk-pci: switch to new API fred.konrad
2013-03-15  9:16 ` [Qemu-devel] [PATCH v8 06/10] virtio-blk-s390: switch to the " fred.konrad
2013-03-15  9:16 ` [Qemu-devel] [PATCH v8 07/10] virtio-blk-ccw switch to " fred.konrad
2013-03-15  9:16 ` [Qemu-devel] [PATCH v8 08/10] virtio-blk: cleanup: init and exit functions fred.konrad
2013-03-15  9:16 ` [Qemu-devel] [PATCH v8 09/10] virtio-blk: cleanup: QOM cast fred.konrad
2013-03-15  9:16 ` fred.konrad [this message]
2013-03-15  9:19 ` [Qemu-devel] [PATCH v8 00/10] virtio-blk refactoring KONRAD Frédéric
2013-03-15 12:44   ` Cornelia Huck
2013-03-15 13:59     ` KONRAD Frédéric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363338999-18210-11-git-send-email-fred.konrad@greensocs.com \
    --to=fred.konrad@greensocs.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=mark.burton@greensocs.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).