qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Benoît Canet" <benoit@irqsave.net>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, "Benoît Canet" <benoit@irqsave.net>,
	stefanha@redhat.com
Subject: [Qemu-devel] [RFC V7 15/32] qcow2: Load and save deduplication table header extension.
Date: Fri, 15 Mar 2013 15:49:29 +0100	[thread overview]
Message-ID: <1363358986-8360-16-git-send-email-benoit@irqsave.net> (raw)
In-Reply-To: <1363358986-8360-1-git-send-email-benoit@irqsave.net>

Signed-off-by: Benoit Canet <benoit@irqsave.net>
---
 block/qcow2.c |   49 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/block/qcow2.c b/block/qcow2.c
index ca38cc3..eaddcb6 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -53,9 +53,18 @@ typedef struct {
     uint32_t len;
 } QCowExtension;
 
+typedef struct {
+    uint64_t offset;
+    int32_t  size;
+    uint8_t  hash_algo;
+    uint8_t  strategies;
+    char     reserved[56];
+} QCowDedupTableExtension;
+
 #define  QCOW2_EXT_MAGIC_END 0
 #define  QCOW2_EXT_MAGIC_BACKING_FORMAT 0xE2792ACA
 #define  QCOW2_EXT_MAGIC_FEATURE_TABLE 0x6803f857
+#define  QCOW2_EXT_MAGIC_DEDUP_TABLE 0xCD8E819B
 
 static int qcow2_probe(const uint8_t *buf, int buf_size, const char *filename)
 {
@@ -84,6 +93,7 @@ static int qcow2_read_extensions(BlockDriverState *bs, uint64_t start_offset,
     QCowExtension ext;
     uint64_t offset;
     int ret;
+    QCowDedupTableExtension dedup_table_extension;
 
 #ifdef DEBUG_EXT
     printf("qcow2_read_extensions: start=%ld end=%ld\n", start_offset, end_offset);
@@ -148,6 +158,25 @@ static int qcow2_read_extensions(BlockDriverState *bs, uint64_t start_offset,
             }
             break;
 
+        case QCOW2_EXT_MAGIC_DEDUP_TABLE:
+            if (ext.len > sizeof(dedup_table_extension)) {
+                fprintf(stderr, "ERROR: dedup_table_extension: len=%u too large"
+                        " (>=%zu)\n",
+                        ext.len, sizeof(dedup_table_extension));
+                return 2;
+            }
+            ret = bdrv_pread(bs->file, offset,
+                             &dedup_table_extension, ext.len);
+            if (ret < 0) {
+                return ret;
+            }
+            s->dedup_table_offset =
+                be64_to_cpu(dedup_table_extension.offset);
+            s->dedup_table_size =
+                be32_to_cpu(dedup_table_extension.size);
+            s->dedup_hash_algo = dedup_table_extension.hash_algo;
+            break;
+
         default:
             /* unknown magic - save it in case we need to rewrite the header */
             {
@@ -959,6 +988,7 @@ int qcow2_update_header(BlockDriverState *bs)
     uint32_t refcount_table_clusters;
     size_t header_length;
     Qcow2UnknownHeaderExtension *uext;
+    QCowDedupTableExtension dedup_table_extension;
 
     buf = qemu_blockalign(bs, buflen);
 
@@ -1062,6 +1092,25 @@ int qcow2_update_header(BlockDriverState *bs)
     buf += ret;
     buflen -= ret;
 
+    if (s->has_dedup) {
+        memset(&dedup_table_extension, 0, sizeof(dedup_table_extension));
+        dedup_table_extension.offset = cpu_to_be64(s->dedup_table_offset);
+        dedup_table_extension.size = cpu_to_be32(s->dedup_table_size);
+        dedup_table_extension.hash_algo = s->dedup_hash_algo;
+        dedup_table_extension.strategies |= QCOW_DEDUP_STRATEGY_RAM;
+        dedup_table_extension.strategies |= QCOW_DEDUP_STRATEGY_RUNNING;
+        ret = header_ext_add(buf,
+                             QCOW2_EXT_MAGIC_DEDUP_TABLE,
+                             &dedup_table_extension,
+                             sizeof(dedup_table_extension),
+                             buflen);
+        if (ret < 0) {
+            goto fail;
+        }
+        buf += ret;
+        buflen -= ret;
+    }
+
     /* Keep unknown header extensions */
     QLIST_FOREACH(uext, &s->unknown_header_ext, next) {
         ret = header_ext_add(buf, uext->magic, uext->data, uext->len, buflen);
-- 
1.7.10.4

  parent reply	other threads:[~2013-03-15 14:51 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-15 14:49 [Qemu-devel] [RFC V7 00/32] QCOW2 deduplication core functionality Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 01/32] qcow2: Add deduplication to the qcow2 specification Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 02/32] qmp: Add DedupStatus enum Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 03/32] qcow2: Add deduplication structures and fields Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 04/32] qcow2: Add qcow2_dedup_read_missing_and_concatenate Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 05/32] qcow2: Create a way to link to l2 tables when deduplicating Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 06/32] qcow2: Make qcow2_update_cluster_refcount public Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 07/32] qcow2: Add qcow2_dedup and related functions Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 08/32] qcow2: Add qcow2_dedup_store_new_hashes Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 09/32] qcow2: Do allocate on rewrite on the dedup case Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 10/32] qcow2: Implement qcow2_compute_cluster_hash Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 11/32] qcow2: Add qcow2_dedup_grow_table and use it Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 12/32] qcow2: Makes qcow2_alloc_cluster_link_l2 mark to deduplicate clusters Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 13/32] qcow2: make the deduplication forget a cluster hash when a cluster is to dedupe Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 14/32] qcow2: Create qcow2_is_cluster_to_dedup Benoît Canet
2013-03-15 14:49 ` Benoît Canet [this message]
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 16/32] qcow2: Extract qcow2_do_table_init Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 17/32] qcow2-cache: Allow to choose table size at creation Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 18/32] qcow2: Extract qcow2_set_incompat_feature and qcow2_clear_incompat_feature Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 19/32] block: Add qcow2_dedup format and image creation code Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 20/32] qcow2: Drop hash for a given cluster when dedup makes refcount > 2^16/2 Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 21/32] qcow2: Remove hash when cluster is deleted Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 22/32] qcow2: Add qcow2_dedup_is_running to probe if dedup is running Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 23/32] qcow2: Integrate deduplication in qcow2_co_writev loop Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 24/32] qcow2: Serialize write requests when deduplication is activated Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 25/32] qcow2: Adapt checking of QCOW_OFLAG_COPIED for dedup Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 26/32] qcow2: Add check_dedup_l2 in order to check l2 of dedup table Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 27/32] qcow2: Add verification " Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 28/32] qcow2: Integrate SKEIN hash algorithm in deduplication Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 29/32] qcow: Set large dedup hash block size Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 30/32] qcow2: Add qcow2_dedup_init and qcow2_dedup_close Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 31/32] qcow2: Add qcow2_co_dedup_resume to restart deduplication Benoît Canet
2013-03-15 14:49 ` [Qemu-devel] [RFC V7 32/32] qcow2: Enable the deduplication feature Benoît Canet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363358986-8360-16-git-send-email-benoit@irqsave.net \
    --to=benoit@irqsave.net \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).