From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGWLR-0007zT-B7 for qemu-devel@nongnu.org; Fri, 15 Mar 2013 11:15:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UGWLO-0004Ai-NO for qemu-devel@nongnu.org; Fri, 15 Mar 2013 11:14:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22779) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGWLO-0004AZ-Fa for qemu-devel@nongnu.org; Fri, 15 Mar 2013 11:14:54 -0400 From: Stefan Hajnoczi Date: Fri, 15 Mar 2013 16:14:11 +0100 Message-Id: <1363360465-5247-15-git-send-email-stefanha@redhat.com> In-Reply-To: <1363360465-5247-1-git-send-email-stefanha@redhat.com> References: <1363360465-5247-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH 14/28] qcow2: drop unnecessary flush in qcow2_update_snapshot_refcount() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori We already flush when the function completes. There is no need to flush after every compressed cluster. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 92519ea..9bfb390 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount.c @@ -790,10 +790,6 @@ int qcow2_update_snapshot_refcount(BlockDriverState *bs, if (ret < 0) { goto fail; } - - /* TODO Flushing once for the whole function should - * be enough */ - bdrv_flush(bs->file); } /* compressed clusters are never modified */ refcount = 2; -- 1.8.1.4