From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGWLt-0000XN-0q for qemu-devel@nongnu.org; Fri, 15 Mar 2013 11:15:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UGWLo-0004YQ-SM for qemu-devel@nongnu.org; Fri, 15 Mar 2013 11:15:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8591) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGWLo-0004Y9-Jd for qemu-devel@nongnu.org; Fri, 15 Mar 2013 11:15:20 -0400 From: Stefan Hajnoczi Date: Fri, 15 Mar 2013 16:14:24 +0100 Message-Id: <1363360465-5247-28-git-send-email-stefanha@redhat.com> In-Reply-To: <1363360465-5247-1-git-send-email-stefanha@redhat.com> References: <1363360465-5247-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH 27/28] qemu-iotests: use -nographic in test case 007 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori A comment explains that -nographic hangs test case 007. This is no longer the case so add -nographic. This makes the test suite faster and more pleasant to run since no windows pop up. I am not sure exactly when -nographic starting working for this case but there is no fundamental reason why graphics are needed here. Make sure the serial port is not on stdio, it would conflict with the monitor. Also remove unnecessary trailing whitespace on these lines. Signed-off-by: Stefan Hajnoczi Tested-by: Kevin Wolf --- tests/qemu-iotests/007 | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/007 b/tests/qemu-iotests/007 index 0139264..c454f2c 100755 --- a/tests/qemu-iotests/007 +++ b/tests/qemu-iotests/007 @@ -50,10 +50,9 @@ _make_test_img 1M for i in `seq 1 10`; do echo "savevm $i" - # XXX(hch): adding -nographic would be good, but hangs the test - $QEMU -hda $TEST_IMG -monitor stdio >/dev/null 2>&1 </dev/null 2>&1 <