From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org
Cc: Peter Lieven <pl@kamp.de>
Subject: [Qemu-devel] [PATCHv2 4/9] bitops: use vector algorithm to optimize find_next_bit()
Date: Fri, 15 Mar 2013 16:50:13 +0100 [thread overview]
Message-ID: <1363362619-3190-5-git-send-email-pl@kamp.de> (raw)
In-Reply-To: <1363362619-3190-1-git-send-email-pl@kamp.de>
this patch adds the usage of buffer_find_nonzero_offset()
to skip large areas of zeroes.
compared to loop unrolling presented in an earlier
patch this adds another 50% performance benefit for
skipping large areas of zeroes. loop unrolling alone
added close to 100% speedup.
Signed-off-by: Peter Lieven <pl@kamp.de>
---
util/bitops.c | 26 +++++++++++++++++++++++---
1 file changed, 23 insertions(+), 3 deletions(-)
diff --git a/util/bitops.c b/util/bitops.c
index e72237a..3c301fa 100644
--- a/util/bitops.c
+++ b/util/bitops.c
@@ -42,10 +42,30 @@ unsigned long find_next_bit(const unsigned long *addr, unsigned long size,
size -= BITS_PER_LONG;
result += BITS_PER_LONG;
}
- while (size & ~(BITS_PER_LONG-1)) {
- if ((tmp = *(p++))) {
- goto found_middle;
+ while (size >= BITS_PER_LONG) {
+ if ((tmp = *p)) {
+ goto found_middle;
+ }
+ if (((uintptr_t) p) % sizeof(VECTYPE) == 0
+ && size >= BITS_PER_BYTE * sizeof(VECTYPE)
+ * BUFFER_FIND_NONZERO_OFFSET_UNROLL_FACTOR) {
+ unsigned long tmp2 =
+ buffer_find_nonzero_offset(p, ((size / BITS_PER_BYTE) &
+ ~(BUFFER_FIND_NONZERO_OFFSET_UNROLL_FACTOR *
+ sizeof(VECTYPE) - 1)));
+ result += tmp2 * BITS_PER_BYTE;
+ size -= tmp2 * BITS_PER_BYTE;
+ p += tmp2 / sizeof(unsigned long);
+ if (!size) {
+ return result;
+ }
+ if (tmp2) {
+ if ((tmp = *p)) {
+ goto found_middle;
+ }
+ }
}
+ p++;
result += BITS_PER_LONG;
size -= BITS_PER_LONG;
}
--
1.7.9.5
next prev parent reply other threads:[~2013-03-15 16:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 15:50 [Qemu-devel] [PATCHv2 0/9] buffer_is_zero / migration optimizations Peter Lieven
2013-03-15 15:50 ` [Qemu-devel] [PATCHv2 1/9] move vector definitions to qemu-common.h Peter Lieven
2013-03-19 15:35 ` Eric Blake
2013-03-15 15:50 ` [Qemu-devel] [PATCHv2 2/9] cutils: add a function to find non-zero content in a buffer Peter Lieven
2013-03-19 15:54 ` Eric Blake
2013-03-19 16:18 ` Peter Lieven
2013-03-19 16:43 ` Eric Blake
2013-03-19 19:42 ` Peter Lieven
2013-03-15 15:50 ` [Qemu-devel] [PATCHv2 3/9] buffer_is_zero: use vector optimizations if possible Peter Lieven
2013-03-19 16:08 ` Eric Blake
2013-03-19 16:14 ` Peter Lieven
2013-03-19 19:44 ` Peter Lieven
2013-03-15 15:50 ` Peter Lieven [this message]
2013-03-19 16:49 ` [Qemu-devel] [PATCHv2 4/9] bitops: use vector algorithm to optimize find_next_bit() Eric Blake
2013-03-19 19:40 ` Peter Lieven
2013-03-15 15:50 ` [Qemu-devel] [PATCHv2 5/9] migration: search for zero instead of dup pages Peter Lieven
2013-03-19 16:55 ` Eric Blake
2013-03-15 15:50 ` [Qemu-devel] [PATCHv2 6/9] migration: add an indicator for bulk state of ram migration Peter Lieven
2013-03-19 17:32 ` Eric Blake
2013-03-15 15:50 ` [Qemu-devel] [PATCHv2 7/9] migration: do not sent zero pages in bulk stage Peter Lieven
2013-03-19 17:36 ` Eric Blake
2013-03-19 19:35 ` Peter Lieven
2013-03-15 15:50 ` [Qemu-devel] [PATCHv2 8/9] migration: do not search dirty " Peter Lieven
2013-03-19 17:40 ` Eric Blake
2013-03-19 19:29 ` Peter Lieven
2013-03-15 15:50 ` [Qemu-devel] [PATCHv2 9/9] migration: use XBZRLE only after " Peter Lieven
2013-03-19 17:43 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363362619-3190-5-git-send-email-pl@kamp.de \
--to=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).