[Qemu-devel] [PATCH 0/2] documentation fixups for the qga schema

[Qemu-devel] [PATCH 0/2] documentation fixups for the qga schema

[Laszlo Ersek]

Laszlo Ersek (2):
  qga schema: mark optional GuestLogicalProcessor.can-offline with
    #optional
  qga schema: document generic QERR_UNSUPPORTED

 qga/qapi-schema.json |   18 +++++++++++++++---
 1 files changed, 15 insertions(+), 3 deletions(-)

[Qemu-devel] [PATCH 1/2] qga schema: mark optional GuestLogicalProcessor.can-offline with #optional

[Laszlo Ersek]

Suggested-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 qga/qapi-schema.json |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index dac4e6f..2af3515 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -562,9 +562,10 @@
 #
 # @online: Whether the VCPU is enabled.
 #
-# @can-offline: Whether offlining the VCPU is possible. This member is always
-#               filled in by the guest agent when the structure is returned,
-#               and always ignored on input (hence it can be omitted then).
+# @can-offline: #optional Whether offlining the VCPU is possible. This member
+#               is always filled in by the guest agent when the structure is
+#               returned, and always ignored on input (hence it can be omitted
+#               then).
 #
 # Since: 1.5
 ##
-- 
1.7.1

[Qemu-devel] [PATCH 2/2] qga schema: document generic QERR_UNSUPPORTED

[Laszlo Ersek]

Part of the wording was shamelessly stolen from Michael Roth's email.

Suggested-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 qga/qapi-schema.json |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index 2af3515..7155b7a 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -2,6 +2,17 @@
 
 ##
 #
+# General note concerning the use of guest agent interfaces:
+#
+# "unsupported" is a higher-level error than the errors that individual
+# commands might document. The caller should always be prepared to receive
+# QERR_UNSUPPORTED, even if the given command doesn't specify it, or doesn't
+# document any failure mode at all.
+#
+##
+
+##
+#
 # Echo back a unique integer value, and prepend to response a
 # leading sentinel byte (0xFF) the client can check scan for.
 #
-- 
1.7.1

Re: [Qemu-devel] [PATCH 0/2] documentation fixups for the qga schema

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

On 03/15/2013 12:07 PM, Laszlo Ersek wrote:
> Laszlo Ersek (2):
>   qga schema: mark optional GuestLogicalProcessor.can-offline with
>     #optional
>   qga schema: document generic QERR_UNSUPPORTED
> 
>  qga/qapi-schema.json |   18 +++++++++++++++---
>  1 files changed, 15 insertions(+), 3 deletions(-)

Series: Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]

Re: [Qemu-devel] [PATCH 2/2] qga schema: document generic QERR_UNSUPPORTED

[mdroth]

On Fri, Mar 15, 2013 at 07:07:51PM +0100, Laszlo Ersek wrote:
> Part of the wording was shamelessly stolen from Michael Roth's email.

:)

series:

Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>

> 
> Suggested-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  qga/qapi-schema.json |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> index 2af3515..7155b7a 100644
> --- a/qga/qapi-schema.json
> +++ b/qga/qapi-schema.json
> @@ -2,6 +2,17 @@
> 
>  ##
>  #
> +# General note concerning the use of guest agent interfaces:
> +#
> +# "unsupported" is a higher-level error than the errors that individual
> +# commands might document. The caller should always be prepared to receive
> +# QERR_UNSUPPORTED, even if the given command doesn't specify it, or doesn't
> +# document any failure mode at all.
> +#
> +##
> +
> +##
> +#
>  # Echo back a unique integer value, and prepend to response a
>  # leading sentinel byte (0xFF) the client can check scan for.
>  #
> -- 
> 1.7.1
> 

Re: [Qemu-devel] [PATCH 0/2] documentation fixups for the qga schema

[mdroth]

On Fri, Mar 15, 2013 at 07:07:49PM +0100, Laszlo Ersek wrote:
> Laszlo Ersek (2):
>   qga schema: mark optional GuestLogicalProcessor.can-offline with
>     #optional
>   qga schema: document generic QERR_UNSUPPORTED
> 
>  qga/qapi-schema.json |   18 +++++++++++++++---
>  1 files changed, 15 insertions(+), 3 deletions(-)
> 

Thanks, applied to qga branch.