From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50311) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGlLs-0006PL-RN for qemu-devel@nongnu.org; Sat, 16 Mar 2013 03:16:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UGlLq-0007al-Mx for qemu-devel@nongnu.org; Sat, 16 Mar 2013 03:16:24 -0400 Received: from mail-pb0-f52.google.com ([209.85.160.52]:42530) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGlLq-0007aT-8V for qemu-devel@nongnu.org; Sat, 16 Mar 2013 03:16:22 -0400 Received: by mail-pb0-f52.google.com with SMTP id ma3so4773367pbc.39 for ; Sat, 16 Mar 2013 00:16:20 -0700 (PDT) From: Alexey Kardashevskiy Date: Sat, 16 Mar 2013 18:16:10 +1100 Message-Id: <1363418170-3391-1-git-send-email-aik@ozlabs.ru> Subject: [Qemu-devel] [PATCH] scsi-bus: fix endianness bug in store_lun() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Alexey Kardashevskiy , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, David Gibson SCSI protocol is defined as big endian. The SCSI command REPORT_LUNS returns the list of LUNs, 8 bytes each. The store_lun() function is called from scsi_target_emulate_report_luns() to fill the LUNs list which is sent later to a guest a response. However it puts the 2 bytes long big-endian value while it is 8 bytes long. The patch fixes it. Tested on PPC64 platform. Signed-off-by: Alexey Kardashevskiy --- hw/scsi-bus.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index a97f1cd..7059dc2 100644 --- a/hw/scsi-bus.c +++ b/hw/scsi-bus.c @@ -310,11 +310,11 @@ struct SCSITargetReq { static void store_lun(uint8_t *outbuf, int lun) { if (lun < 256) { - outbuf[1] = lun; + outbuf[7] = lun; return; } - outbuf[1] = (lun & 255); - outbuf[0] = (lun >> 8) | 0x40; + outbuf[7] = (lun & 255); + outbuf[6] = (lun >> 8) | 0x40; } static bool scsi_target_emulate_report_luns(SCSITargetReq *r) -- 1.7.10.4