From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHZqS-0003ea-8g for qemu-devel@nongnu.org; Mon, 18 Mar 2013 09:11:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UHZqQ-0000hY-3X for qemu-devel@nongnu.org; Mon, 18 Mar 2013 09:11:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8222) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHZqP-0000hN-T2 for qemu-devel@nongnu.org; Mon, 18 Mar 2013 09:11:18 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2IDBH3B030825 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 18 Mar 2013 09:11:17 -0400 From: Alon Levy Date: Mon, 18 Mar 2013 15:10:47 +0200 Message-Id: <1363612272-13713-2-git-send-email-alevy@redhat.com> In-Reply-To: <1363612272-13713-1-git-send-email-alevy@redhat.com> References: <1363612272-13713-1-git-send-email-alevy@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH 01/26] libcacard: correct T0 historical bytes size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mlureau@redhat.com From: Marc-Andr=C3=A9 Lureau The VCARD_ATR_PREFIX macro adds a prefix of 6 characters only. pcsc_scan was complaining before the patch: + Historical bytes: 56 43 41 52 44 5F 4E 53 53 ERROR! ATR is truncated: 2 byte(s) is/are missing --- libcacard/vcardt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libcacard/vcardt.h b/libcacard/vcardt.h index d3e9522..538bdde 100644 --- a/libcacard/vcardt.h +++ b/libcacard/vcardt.h @@ -26,7 +26,7 @@ typedef struct VCardEmulStruct VCardEmul; #define MAX_CHANNEL 4 =20 /* create an ATR with appropriate historical bytes */ -#define VCARD_ATR_PREFIX(size) 0x3b, 0x68+(size), 0x00, 0xff, \ +#define VCARD_ATR_PREFIX(size) 0x3b, 0x66+(size), 0x00, 0xff, \ 'V', 'C', 'A', 'R', 'D', '_' =20 =20 --=20 1.8.1.4