From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHe3r-0001lp-Gi for qemu-devel@nongnu.org; Mon, 18 Mar 2013 13:41:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UHe3m-00045E-CE for qemu-devel@nongnu.org; Mon, 18 Mar 2013 13:41:27 -0400 Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.d.1.0.0.b.8.0.1.0.0.2.ip6.arpa ([2001:8b0:1d0::1]:33001 helo=mnementh.archaic.org.uk) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHe3m-00044X-56 for qemu-devel@nongnu.org; Mon, 18 Mar 2013 13:41:22 -0400 From: Peter Maydell Date: Mon, 18 Mar 2013 17:41:20 +0000 Message-Id: <1363628480-29306-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH] pl050: Don't send always-constant is_mouse field List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: patches@linaro.org The is_mouse field of the pl050 state structure is constant (it tracks whether this is a 'pl050_keyboard' or 'pl050_mouse'), so there's no need to include it in the VMState structure. Signed-off-by: Peter Maydell --- It doesn't hurt to carry around the is_mouse field, I guess, but I thought it nicer to do the cleanup now while we still don't care about between version migration. hw/pl050.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/pl050.c b/hw/pl050.c index bc31ab6..76735a0 100644 --- a/hw/pl050.c +++ b/hw/pl050.c @@ -24,14 +24,13 @@ typedef struct { static const VMStateDescription vmstate_pl050 = { .name = "pl050", - .version_id = 1, - .minimum_version_id = 1, + .version_id = 2, + .minimum_version_id = 2, .fields = (VMStateField[]) { VMSTATE_UINT32(cr, pl050_state), VMSTATE_UINT32(clk, pl050_state), VMSTATE_UINT32(last, pl050_state), VMSTATE_INT32(pending, pl050_state), - VMSTATE_INT32(is_mouse, pl050_state), VMSTATE_END_OF_LIST() } }; -- 1.7.9.5